-
-
Notifications
You must be signed in to change notification settings - Fork 399
Allow Literals in 'Size of' #7961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Literals in 'Size of' #7961
Conversation
This may cause some breaking changes with things like |
…nt' into patch/allow-literals-in-expramount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, you can replace the switch with an enhanced switch though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still needs some tests to check if behavior changed! eg (size of {a::*} and 1)
Problem
There is an extremely old check that stops Literals from being used in
size of
expression which recently became an issue in my Timezone Support PR. After discussion we decided to euthanize itThere is also another bug with ExprAmount that makes
{a}
count towardsrecursive size of {a::*}
which was fixed in this PRSolution
Removes the check that stops Literals from being used
Caution
Breaking change:
when using
size of {a::*}, "b"
:old behavior
(size of {a::*}), "b"
new behavior
size of ({a::*}, "b")
Testing Completed
ExprAmount.sk
Supporting Information
Completes: none
Related: none