-
Notifications
You must be signed in to change notification settings - Fork 164
Improve a test in Common.Certificates #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- more cert tests using both default and named options - use SpinUntil instead of Task.Delay for file system operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Should probably dispose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting PR approval due to failing tests in cibuild.
Wouldn't it be easier to test via |
Description
Wrap
RegisterChangeCallback
in usings, resetchangeCalled
boolean between changesFixes #1506
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.