Improve ghoul behaviour (rebase+fix) #3230
Conversation
Hypernoot
force-pushed
the
ghoul-behaviour-hypernoot
branch
from
075ed0d to
58ecade
Compare
Hypernoot
force-pushed
the
ghoul-behaviour-hypernoot
branch
from
58ecade to
474d246
Compare
|
Looking pretty good so far. A few suggestions I have:
|
|
well it seems my issue with the ghoul not moving is fixed lol |
|
Thanks for review!
Can you please elaborate on what that means in particular?
That is already implemented but the default tracking range is quite large. You can set it to a lower value to actually see it. The default value can be reduced if needed.
The stunning time is now 5s. I can reduce it to maybe 3s. |
Currently, when the player is higher than Ghoul, Ghoul does simply push itself relatively straight upwards whlie slowly moving towards him. What I had in mind was closer to the Blooper from Mario, in that instead of going straight up, Ghoul pushes itself towards Tux, so more diagonal-up. They only move with every thrust, standing still before charging up another thrust to move closer to Tux again. Like a jellyfish.
Nice, I'll have to try out a few values then to find a good default.
Try 4. Should be enough. |
|
As you may have noticed, when the ghoul is bellow its target position, he jumps upwards by a defined step. When Tux is above ghoul but not much higher, then a single jump may suffice for the ghoul to reach Tux. If Tux is higher than that, then the ghoul actually makes multiple consecutive jumps to reach Tux. Shall I make the jumps shorter to make it more apparent? |
You could give it a try and I'll give that a look |
|
@Rusty-Box Thanks for input, you can try it now ^.^ |
|
Yeah, so the horizontal speed is still very low when going up. The idea was that it moves faster horizontally too when it thrusts itself upwards. The speed when it goes down is fine but should have much more speed per thrust horizontally. |
|
@Rusty-Box feel free to check |
There was a problem hiding this comment.
https://github.com/user-attachments/assets/41a62f15-8ab7-43e4-b6ed-0116e0dba26d
there's a bug where a ghoul will sometimes trusts backwards? in which it seems to have no speed cap or something, causing it to go flying
| break; | ||
| default: | ||
| break; | ||
| const float vy = (UP_VELOCITY + DOWN_VELOCITY) / 2.0f; |
There was a problem hiding this comment.
What is this value I keep seeing? What does it mean? The upwards thrust velocity?
There was a problem hiding this comment.
It is the mean velocity of linearly accelerated movement.
| { | ||
| const float vx = m_physic.get_velocity_x(); | ||
| const float ax = m_physic.get_acceleration_x(); | ||
| if (vx * ax > 0) { |
There was a problem hiding this comment.
What is vx * ax? The resulting x velocity when affected by the acceleration?
There was a problem hiding this comment.
It tests whether vx and ax have the same sign, similar to the dot product.
There was a problem hiding this comment.
| if (vx * ax > 0) { | |
| if (std::signbit(vx) == std::signbit(ax)) { |
There was a problem hiding this comment.
Yes, but I don't want the condition to trigger when either vx or ax is zero.
|
ok testing it further, setting the speed really low causes the ghoul to fly backwards. tbh idk why you can even set the speed i think it might be best to just make you not able to edit it? |
|
Good catch! I will remove the speed setting completely, you can't choose the speed of most badguys, so there's no point why this one should be changeable. |
[ci-skip]
a fixed and rebased version of #2848