-
Notifications
You must be signed in to change notification settings - Fork 414
Add more Lua functions for TAStudio markers #4335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
src/BizHawk.Client.EmuHawk/tools/Lua/Libraries/TAStudioLuaLibrary.cs
Outdated
Show resolved
Hide resolved
At first glance it looks those functions can do everything that was possible with my PR. |
I think it would be good to handle the case where the specified branch doesn't exist. So that |
src/BizHawk.Client.EmuHawk/tools/Lua/Libraries/TAStudioLuaLibrary.cs
Outdated
Show resolved
Hide resolved
Actually, branches have an Existing function |
Co-Authored-By: c7fab <26490633+c7fab@users.noreply.github.com>
Please provide a summary for dummmies, I don't have the capacity to remember how this is different from all the previous variants and I can't review it by looking at the technical side. |
diff between force push |
I don't really like the idea of using the current marker set when the given branch ID doesn't exist. I also think that the documentation given to users should specify what happens when the input is invalid. |
Based on #4272 by @c7fab (thank you, and please let us know if this is insufficient for your use case).