Skip to content

Upgrade eslint #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 26, 2025
Merged

Upgrade eslint #1337

merged 6 commits into from
May 26, 2025

Conversation

error-four-o-four
Copy link
Contributor

adresses #1251

  1. Please make all pull requests on the dev branch ✅
  2. Don't commit build files ✅
  3. Try to get all tests to pass ✅

- Modified linting scripts in package.json to improve linting coverage and ease of use.
- Updated ESLint and related plugins to their latest versions.
- Removed unnecessary eslint-disable comments from various scripts.
@typescript-eslint/no-unused-expressions
@typescript-eslint/no-unused-vars
- Modified the "lint" script to run TypeScript compiler with noEmit before ESLint.
- Updated "lint:fix" to include TypeScript checks and fix linting issues in both Tone and test directories.
- Removed unused ESLint plugin dependency "eslint-plugin-file-extension-in-import-ts".
@error-four-o-four error-four-o-four marked this pull request as ready for review May 25, 2025 12:40
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (c322584) to head (a082eec).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1337      +/-   ##
==========================================
- Coverage   98.96%   98.95%   -0.01%     
==========================================
  Files         203      203              
  Lines       22727    22725       -2     
  Branches     1004     1004              
==========================================
- Hits        22491    22487       -4     
- Misses        236      238       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tambien tambien merged commit 3754f13 into Tonejs:dev May 26, 2025
9 checks passed
@error-four-o-four error-four-o-four deleted the upgrade-eslint branch May 27, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants