Unicode charcter \u 2002 included in detections #96
Comments
|
I would love to open a PR with a fix if I'll be granted push permissions |
|
You don't need push permissions to contribute. Your PR is welcome! |
vincentkoc
added a commit
to vincentkoc/Parser-PHP
that referenced
this issue
Jan 19, 2019
|
I've added Pull Request #106 which fixes this issue |
vincentkoc
added a commit
to vincentkoc/Parser-JavaScript
that referenced
this issue
Jan 20, 2019
Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106
|
Added another PR in the JS Library for WhichBrowser patching the same issue there in the JS datafiles WhichBrowser/Parser-JavaScript#29 |
vincentkoc
added a commit
to vincentkoc/Parser-JavaScript
that referenced
this issue
Jan 22, 2019
Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106
mariotsi
added a commit
to WhichBrowser/Parser-JavaScript
that referenced
this issue
Feb 6, 2019
#33) * Removing Unicode EN+Space for Space Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106 * Removing Unicode EN+Space for Space Removing references of u\2002 in data files and unit tests. Originally reported on PHP library WhichBrowser/Parser-PHP#96 - And same PR built for PHP ported to JS library WhichBrowser/Parser-PHP#106 * Now update-profiles.js and update-models.js strip away EN+SPACE character as requested on #32 * Revert changes to data files. These files are automatically generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey
In quite a few detections we get a result of \u2002 inside the model instead of a space,
E.g. GALAXY Note 8 SC-01K instead of GALAXY Note 8 SC-01K.
Do note that this problem is sourced in data files and can be easily fixed with a find-replace
The text was updated successfully, but these errors were encountered: