SoleXplorer compatibility #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PasoStudio73
added
the
suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when performing a sprinkle to the model, to obtain a Sole compatible model, and prediction, the function sprinkle creates a Sole model but actual predictions aren't written in Sole struct (under the struct 'info') instead are passed as a second parameter.
SoleXplorer expets to find predictions inside the model, under info struct.
in order to have sprinkle properly working for SoleXplorer, i've added a function in mlj fit interface: 'translate_model', called by sprinkle in place of 'translate_function' that I kept as it is for safety.
the difference between translate_model and translate_function is that the first one accepts also predictions as a vector of string.
then, call translate function to convert the tree.
I also make a little change in translate function: since it return a wrong supporting predictions, if a vector of predictions is passed, it will be merged.