Skip to content

[fix](cluster)fix fe host may be contains Scope Identifier #52076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

[fix](cluster)fix fe host may be contains Scope Identifier #52076

merged 1 commit into from
Jun 26, 2025

Conversation

zddr
Copy link
Contributor

@zddr zddr commented Jun 20, 2025 •
edited
Loading

What problem does this PR solve?

fe host may be like: 2408:400a:5a:ea00:2fb5:112e:39dd:9bba%eth0

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
fix fe host may be contains Scope Identifier

Release note

fix fe host may be contains Scope Identifier

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Jun 20, 2025

run buildall

@morrySnow morrySnow changed the title [fix](ipv6)fix fe host may be contains Scope Identifier [fix](cluster)fix fe host may be contains Scope Identifier Jun 20, 2025
@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉
Increment coverage report
Complete coverage report

@zddr
Copy link
Contributor Author

zddr commented Jun 25, 2025

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 34137 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 56c45ae4527b06b860d7035fe1f808f41cbdacd5, data reload: false

------ Round 1 ----------------------------------
q1	17587	5212	5072	5072
q2	2025	297	188	188
q3	10282	1292	759	759
q4	10241	1017	523	523
q5	7765	2426	2346	2346
q6	177	162	133	133
q7	915	734	597	597
q8	9316	1303	1097	1097
q9	6899	5128	5137	5128
q10	6907	2373	1962	1962
q11	506	302	276	276
q12	339	354	223	223
q13	17799	3685	3105	3105
q14	242	233	218	218
q15	560	477	489	477
q16	435	437	379	379
q17	627	904	394	394
q18	7641	7274	7129	7129
q19	1433	958	560	560
q20	354	344	249	249
q21	3789	3223	2340	2340
q22	1070	1057	982	982
Total cold run time: 106909 ms
Total hot run time: 34137 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5162	5071	5133	5071
q2	243	340	233	233
q3	2172	2648	2323	2323
q4	1347	1816	1358	1358
q5	4250	4396	4406	4396
q6	216	168	127	127
q7	2019	1940	1766	1766
q8	2595	2508	2628	2508
q9	7127	7163	7155	7155
q10	3132	3247	2859	2859
q11	560	528	527	527
q12	720	803	615	615
q13	3493	3867	3369	3369
q14	281	291	261	261
q15	526	481	480	480
q16	435	460	422	422
q17	1106	1502	1311	1311
q18	7385	7319	6971	6971
q19	812	842	878	842
q20	1908	1988	1811	1811
q21	4819	4350	4307	4307
q22	1125	1071	999	999
Total cold run time: 51433 ms
Total hot run time: 49711 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187198 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 56c45ae4527b06b860d7035fe1f808f41cbdacd5, data reload: false

query1	978	395	411	395
query2	6548	1825	1807	1807
query3	6749	227	221	221
query4	26514	23799	23569	23569
query5	4373	622	465	465
query6	322	215	214	214
query7	4623	493	289	289
query8	274	230	225	225
query9	8596	2641	2664	2641
query10	500	363	279	279
query11	15659	15028	14863	14863
query12	172	115	109	109
query13	1663	545	418	418
query14	9517	6079	6145	6079
query15	207	206	181	181
query16	7297	633	497	497
query17	1206	753	611	611
query18	2000	418	316	316
query19	199	205	166	166
query20	122	121	119	119
query21	222	128	112	112
query22	4168	4072	3977	3977
query23	34015	33046	33391	33046
query24	8502	2411	2413	2411
query25	559	459	393	393
query26	1241	273	156	156
query27	2736	512	350	350
query28	4347	2133	2152	2133
query29	778	553	430	430
query30	284	217	195	195
query31	944	828	775	775
query32	71	65	63	63
query33	555	370	332	332
query34	814	878	542	542
query35	786	850	754	754
query36	953	991	913	913
query37	120	103	77	77
query38	4121	4177	4143	4143
query39	1477	1438	1426	1426
query40	206	124	112	112
query41	62	62	60	60
query42	122	115	115	115
query43	503	515	482	482
query44	1332	856	841	841
query45	185	180	175	175
query46	881	1039	649	649
query47	1745	1829	1764	1764
query48	387	415	334	334
query49	721	496	399	399
query50	649	703	406	406
query51	4130	4160	4111	4111
query52	114	109	103	103
query53	231	273	193	193
query54	586	570	510	510
query55	101	98	86	86
query56	301	312	301	301
query57	1179	1196	1110	1110
query58	274	280	272	272
query59	2607	2655	2607	2607
query60	348	317	308	308
query61	128	123	127	123
query62	824	731	692	692
query63	229	193	187	187
query64	4326	1003	678	678
query65	4292	4179	4176	4176
query66	1132	417	316	316
query67	15845	15628	15490	15490
query68	8643	926	539	539
query69	469	314	273	273
query70	1245	1167	1120	1120
query71	478	319	307	307
query72	5607	4787	4919	4787
query73	751	675	369	369
query74	8921	9039	9098	9039
query75	3990	3191	2687	2687
query76	3726	1250	758	758
query77	788	381	313	313
query78	9946	10130	9370	9370
query79	2602	831	589	589
query80	656	527	465	465
query81	470	266	240	240
query82	330	137	108	108
query83	299	264	261	261
query84	291	112	94	94
query85	759	357	319	319
query86	331	326	277	277
query87	4421	4538	4355	4355
query88	3011	2505	2351	2351
query89	422	326	287	287
query90	2096	212	208	208
query91	141	152	113	113
query92	76	61	56	56
query93	2179	983	593	593
query94	680	414	303	303
query95	386	307	290	290
query96	519	599	292	292
query97	2740	2828	2661	2661
query98	233	222	203	203
query99	1414	1395	1279	1279
Total cold run time: 276272 ms
Total hot run time: 187198 ms

@zddr
Copy link
Contributor Author

zddr commented Jun 25, 2025

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 34577 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 56c45ae4527b06b860d7035fe1f808f41cbdacd5, data reload: false

------ Round 1 ----------------------------------
q1	17596	5143	5037	5037
q2	1961	299	192	192
q3	10275	1258	703	703
q4	10233	1018	539	539
q5	7512	2359	2328	2328
q6	184	163	134	134
q7	923	744	626	626
q8	9321	1266	1117	1117
q9	6763	5031	5074	5031
q10	6885	2351	1983	1983
q11	488	295	277	277
q12	346	347	224	224
q13	17748	3639	3057	3057
q14	240	222	225	222
q15	567	478	486	478
q16	438	423	381	381
q17	631	872	386	386
q18	7317	7169	7045	7045
q19	1215	947	562	562
q20	349	351	236	236
q21	4108	3398	3035	3035
q22	1080	1026	984	984
Total cold run time: 106180 ms
Total hot run time: 34577 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5114	5095	5108	5095
q2	270	323	225	225
q3	2217	2659	2270	2270
q4	1354	1764	1400	1400
q5	4222	4371	4386	4371
q6	214	174	135	135
q7	2025	1911	1787	1787
q8	2599	2639	2513	2513
q9	7063	7015	7092	7015
q10	3107	3245	2824	2824
q11	569	519	478	478
q12	688	742	636	636
q13	3538	3853	3388	3388
q14	285	283	262	262
q15	498	483	473	473
q16	440	468	418	418
q17	1101	1473	1338	1338
q18	7255	7036	7032	7032
q19	803	834	856	834
q20	1916	1973	1953	1953
q21	4791	4322	4324	4322
q22	1098	1068	1028	1028
Total cold run time: 51167 ms
Total hot run time: 49797 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185596 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 56c45ae4527b06b860d7035fe1f808f41cbdacd5, data reload: false

query1	987	391	407	391
query2	6532	1835	1826	1826
query3	6745	220	214	214
query4	26197	23789	23028	23028
query5	4624	624	493	493
query6	313	207	206	206
query7	4626	514	297	297
query8	274	225	215	215
query9	8652	2613	2627	2613
query10	514	342	272	272
query11	15828	15219	14892	14892
query12	167	113	109	109
query13	1667	538	410	410
query14	9735	6195	6168	6168
query15	216	202	176	176
query16	7649	626	483	483
query17	1186	730	600	600
query18	2043	415	326	326
query19	202	192	164	164
query20	122	117	120	117
query21	220	128	108	108
query22	4069	4173	4018	4018
query23	33871	33044	33140	33044
query24	7806	2352	2372	2352
query25	533	464	391	391
query26	726	272	155	155
query27	2650	528	350	350
query28	3911	2115	2108	2108
query29	678	545	428	428
query30	294	220	194	194
query31	916	835	753	753
query32	74	64	64	64
query33	516	348	311	311
query34	782	838	538	538
query35	790	796	717	717
query36	921	959	909	909
query37	115	107	73	73
query38	4175	4099	4074	4074
query39	1468	1431	1428	1428
query40	212	124	106	106
query41	65	59	57	57
query42	130	117	105	105
query43	487	498	482	482
query44	1327	829	824	824
query45	176	175	167	167
query46	837	1015	618	618
query47	1782	1806	1751	1751
query48	374	430	309	309
query49	702	503	419	419
query50	632	678	410	410
query51	4096	4125	4097	4097
query52	113	105	96	96
query53	227	256	183	183
query54	586	573	496	496
query55	86	86	92	86
query56	303	300	285	285
query57	1206	1199	1114	1114
query58	264	260	257	257
query59	2585	2596	2553	2553
query60	337	315	344	315
query61	128	138	123	123
query62	792	711	664	664
query63	217	187	185	185
query64	2918	1044	662	662
query65	4256	4192	4197	4192
query66	862	407	330	330
query67	15560	15553	15541	15541
query68	8185	933	521	521
query69	490	302	269	269
query70	1212	1129	1103	1103
query71	458	332	300	300
query72	5341	4669	4646	4646
query73	708	574	356	356
query74	8902	9028	8789	8789
query75	3798	3196	2672	2672
query76	3600	1202	774	774
query77	790	379	280	280
query78	9982	10132	9262	9262
query79	1933	831	583	583
query80	703	531	436	436
query81	477	265	227	227
query82	417	139	104	104
query83	282	255	221	221
query84	297	99	90	90
query85	790	368	317	317
query86	334	304	280	280
query87	4498	4562	4362	4362
query88	2946	2270	2369	2270
query89	375	308	281	281
query90	1927	216	207	207
query91	146	153	110	110
query92	75	59	63	59
query93	1115	944	594	594
query94	679	444	302	302
query95	372	294	287	287
query96	485	563	277	277
query97	2732	2763	2668	2668
query98	218	225	204	204
query99	1498	1389	1303	1303
Total cold run time: 269819 ms
Total hot run time: 185596 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.34 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 56c45ae4527b06b860d7035fe1f808f41cbdacd5, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.04
query3	0.23	0.07	0.07
query4	1.60	0.10	0.10
query5	0.43	0.43	0.42
query6	1.16	0.67	0.67
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.58	0.50	0.51
query10	0.58	0.58	0.59
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.61	0.61
query14	0.80	0.84	0.78
query15	0.89	0.86	0.88
query16	0.39	0.38	0.39
query17	1.07	1.04	1.04
query18	0.22	0.22	0.21
query19	1.94	1.83	1.86
query20	0.02	0.01	0.02
query21	15.38	0.88	0.54
query22	0.76	1.23	0.74
query23	14.80	1.38	0.63
query24	6.87	1.48	0.46
query25	0.52	0.19	0.06
query26	0.54	0.17	0.14
query27	0.07	0.05	0.05
query28	9.69	0.94	0.46
query29	12.60	4.02	3.31
query30	0.25	0.09	0.06
query31	2.84	0.60	0.40
query32	3.27	0.58	0.46
query33	3.06	3.15	3.12
query34	16.06	5.47	4.82
query35	4.86	4.87	4.87
query36	0.69	0.50	0.48
query37	0.09	0.07	0.07
query38	0.05	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.14
query41	0.09	0.03	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.02
Total cold run time: 103.77 s
Total hot run time: 29.34 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 9270ccc into apache:master Jun 26, 2025
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 27, 2025
@zddr
[fix](cluster)fix fe host may be contains Scope Identifier (#52076)
3f65c76 
fe host may be like: 2408:400a:5a:ea00:2fb5:112e:39dd:9bba%eth0
@github-actions github-actions bot mentioned this pull request Jun 27, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 27, 2025
@zddr
[fix](cluster)fix fe host may be contains Scope Identifier (#52076)
3278261 
fe host may be like: 2408:400a:5a:ea00:2fb5:112e:39dd:9bba%eth0
@github-actions github-actions bot mentioned this pull request Jun 27, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 27, 2025
@zddr
[fix](cluster)fix fe host may be contains Scope Identifier (#52076)
80f1ff4 
fe host may be like: 2408:400a:5a:ea00:2fb5:112e:39dd:9bba%eth0
@github-actions github-actions bot mentioned this pull request Jun 27, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jun 27, 2025
@github-actions @zddr
branch-3.1: [fix](cluster)fix fe host may be contains Scope Identifier …
d685132 
…#52076 (#52397)

Cherry-picked from #52076

Co-authored-by: zhangdong <zhangdong@selectdb.com>
yiguolei pushed a commit that referenced this pull request Jun 28, 2025
@github-actions @zddr
branch-2.1: [fix](cluster)fix fe host may be contains Scope Identifier …
d7184af 
…#52076 (#52398)

Cherry-picked from #52076

Co-authored-by: zhangdong <zhangdong@selectdb.com>
dataroaring pushed a commit that referenced this pull request Jul 1, 2025
@github-actions @zddr
branch-3.0: [fix](cluster)fix fe host may be contains Scope Identifier …
f92ace3 
…#52076 (#52396)

Cherry-picked from #52076

Co-authored-by: zhangdong <zhangdong@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jul 3, 2025
@github-actions @zddr @koarz
branch-3.0: [fix](cluster)fix fe host may be contains Scope Identifier …
ea310f2 
…apache#52076 (apache#52396)

Cherry-picked from apache#52076

Co-authored-by: zhangdong <zhangdong@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999

@morrySnow morrySnow

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.11-merged dev/3.0.7-merged dev/3.1.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zddr @hello-stephen @doris-robot @starocean999 @morrySnow @yiguolei @dataroaring