Skip to content

feat(cloudwatch): add option to show labels on pie chart #34745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(cloudwatch): add option to show labels on pie chart #34745

wants to merge 3 commits into from

Conversation

Kasra-G
Copy link

@Kasra-G Kasra-G commented Jun 18, 2025 •
edited
Loading

Issue # (if applicable)

Closes #28929

Reason for this change

Cloudwatch Dashboard console has this option but cdk GraphWidget does not

Description of changes

  • adds a new optional boolean parameter to GraphWidgetProps called displayLabelsOnChart
    • naming obtained from description of the option in the AWS Console
  • updates aws-cloudwatch README.md with sample usage

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Created new unit and integration test and ran them

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 18, 2025 05:38
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jun 18, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 18, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@Kasra-G Kasra-G changed the title feat(aws-cloudwatch): add option to show labels on pie chart feat(cloudwatch): add option to show labels on pie chart Jun 18, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 18, 2025 05:51

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@Kasra-G Kasra-G marked this pull request as ready for review June 18, 2025 05:54
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 18, 2025
@Kasra-G Kasra-G force-pushed the ft/aws-cloudwatch/labeled-pie branch from f2c794c to b120954 Compare June 19, 2025 08:13
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b120954
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(aws-cloudwatch): support labels on pie charts
2 participants
@Kasra-G @aws-cdk-automation