Skip to content

docs(eks): fix heading levels for Auto Mode #34783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Jun 21, 2025

The heading levels for Auto Mode are inappropriate.
I think the Auto Mode sections would be better placed under Provision Clusters to align with other node types.

image

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 21, 2025 08:58
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jun 21, 2025
@azharu
Copy link

azharu commented Jun 21, 2025

There are redundant headers ("Using Auto Mode" and "Node Pools" appear twice)
Good explanation of the difference between aws-eks and aws-eks-v2 , Links to official documentation are valuable

@mazyu36
Copy link
Contributor Author

mazyu36 commented Jun 22, 2025

I understand that it’s under the EKS Auto Mode section, but I think it’s okay to keep the header since it helps clarify the structure. I’ve decided to leave it as-is for now out of respect for the original.
I’d like to wait and hear the maintainer’s opinion.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d0d2dee
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants