Skip to content

[PM-15160] Create ResellerClientOrganizationSignUpCommand #5981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Jun 18, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15160

📔 Objective

Extract IOrganizationService.CreatePendingOrganization into a command.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

r-tome added 4 commits June 18, 2025 15:12
…ller client organizations with email invitations and error handling
…sellerClientOrganizationSignUpCommand for organization sign-up process
Copy link
Contributor

github-actions bot commented Jun 18, 2025

Logo
Checkmarx One – Scan Summary & Detailsdadbbfca-3984-4c39-970c-acae3a8aeb6b

Great job, no security vulnerabilities found in this Pull Request

@r-tome r-tome marked this pull request as ready for review June 18, 2025 15:50
@r-tome r-tome requested a review from a team as a code owner June 18, 2025 15:50
@r-tome r-tome requested a review from BTreston June 18, 2025 15:50
@r-tome r-tome changed the title [PM-15160] Create ResellerClientOrganizationSignUpCommand command [PM-15160] Create ResellerClientOrganizationSignUpComman Jun 18, 2025
@r-tome r-tome changed the title [PM-15160] Create ResellerClientOrganizationSignUpComman [PM-15160] Create ResellerClientOrganizationSignUpCommand Jun 18, 2025
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 98.61111% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.68%. Comparing base (cc07f13) to head (a2ccadb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...in/AdminConsole/Controllers/ProvidersController.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5981      +/-   ##
==========================================
+ Coverage   47.62%   47.68%   +0.06%     
==========================================
  Files        1688     1689       +1     
  Lines       74888    74937      +49     
  Branches     6756     6757       +1     
==========================================
+ Hits        35663    35732      +69     
+ Misses      37768    37748      -20     
  Partials     1457     1457              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@r-tome r-tome merged commit 494c41e into main Jun 24, 2025
43 of 45 checks passed
@r-tome r-tome deleted the ac/pm-15160/create-providerclientorganizationsignup-command branch June 24, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants