Skip to content

[SM-1273] Adding new logging for secrets #5991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cd-bitwarden
Copy link
Contributor

@cd-bitwarden cd-bitwarden commented Jun 20, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1273

📔 Objective

Server side changes to call new functions that will insert event logs for secrets when they are accessed, deleted, created and updated.

📸 Screenshots

UI Overview and what to expect:
https://www.loom.com/share/9670bdbd7a374c0ab12d69cccd341e0e?sid=3ea594a9-1546-4abf-8444-97f958b93e94

Code Changes:
https://www.loom.com/share/0309cfcd4ff64d23b4f08aa3d7af7de0?sid=5230ad73-54f0-4197-ab0d-90cdc1e3d167

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cd-bitwarden cd-bitwarden requested a review from a team as a code owner June 20, 2025 21:10
@cd-bitwarden cd-bitwarden requested a review from BTreston June 20, 2025 21:10
Copy link
Contributor

github-actions bot commented Jun 20, 2025

Logo
Checkmarx One – Scan Summary & Details1bd2858d-d731-494e-9a93-9fca8de076b6

New Issues (1)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 164
detailsMethod Put at line 164 of /src/Api/AdminConsole/Controllers/GroupsController.cs gets a parameter from a user request from model. This parameter v...
ID: yt2PajNvte2IY7Xe%2FRtOPf8qKlo%3D
Attack Vector

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.

Project coverage is 47.72%. Comparing base (2af4e9c) to head (447312e).

Files with missing lines Patch % Lines
...inConsole/Services/Implementations/EventService.cs 38.88% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5991       +/-   ##
===========================================
+ Coverage   11.12%   47.72%   +36.60%     
===========================================
  Files         994     1692      +698     
  Lines       43786    74991    +31205     
  Branches     3464     6759     +3295     
===========================================
+ Hits         4870    35792    +30922     
+ Misses      38820    37743     -1077     
- Partials       96     1456     +1360     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants