-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[SM-1273] Adding new logging for secrets #5991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
New Issues (1)Checkmarx found the following issues in this Pull Request
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5991 +/- ##
===========================================
+ Coverage 11.12% 47.72% +36.60%
===========================================
Files 994 1692 +698
Lines 43786 74991 +31205
Branches 3464 6759 +3295
===========================================
+ Hits 4870 35792 +30922
+ Misses 38820 37743 -1077
- Partials 96 1456 +1360 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1273
📔 Objective
Server side changes to call new functions that will insert event logs for secrets when they are accessed, deleted, created and updated.
📸 Screenshots
UI Overview and what to expect:
https://www.loom.com/share/9670bdbd7a374c0ab12d69cccd341e0e?sid=3ea594a9-1546-4abf-8444-97f958b93e94
Code Changes:
https://www.loom.com/share/0309cfcd4ff64d23b4f08aa3d7af7de0?sid=5230ad73-54f0-4197-ab0d-90cdc1e3d167
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes