Skip to content

Commit c3a6c7e

Browse files
committed
Fix shift blowup without arguments
1 parent ea7275d commit c3a6c7e

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

rootfs_overlay/lkmc/fops.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set -e
44
# Setup
55
f=/sys/kernel/debug/lkmc_fops
66
mod="${1:-fops.ko}"
7-
shift
7+
[ $# -gt 1] && shift
88
insmod "$mod" "$@"
99

1010
# read

rootfs_overlay/lkmc/memfile.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ odraw() (
99
# Setup
1010
f=/sys/kernel/debug/lkmc_memfile
1111
mod="${1:-memfile.ko}"
12-
shift
12+
[ $# -gt 1] && shift
1313
insmod "$mod" "$@"
1414

1515
# Starts off empty

rootfs_overlay/lkmc/scull.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ set -eux
44
name=scull
55

66
mod="${1:-$name.ko}"
7-
shift
7+
[ $# -gt 1] && shift
88
insmod "$mod" "$@"
99
major="$(awk "\$2==\"$name\" {print \$1}" /proc/devices)"
1010

rootfs_overlay/lkmc/seq_file.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
set -e
33
f=/sys/kernel/debug/lkmc_seq_file
44
mod="${1:-seq_file.ko}"
5-
shift
5+
[ $# -gt 1] && shift
66
insmod "$mod" "$@"
77
[ "$(cat "$f")" = "$(printf '0\n1\n2\n')" ]
88
[ "$(cat "$f")" = "$(printf '0\n1\n2\n')" ]

rootfs_overlay/lkmc/seq_file_single_open.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
set -e
33
f=/sys/kernel/debug/lkmc_seq_file_single_open
44
mod="${1:-seq_file_single_open.ko}"
5-
shift
5+
[ $# -gt 1] && shift
66
insmod "$mod" "$@"
77
[ "$(cat "$f")" = "$(printf 'ab\ncd\n')" ]
88
[ "$(dd if="$f" bs=1 count=3 skip=1)" = "$(printf "b\nc\n")" ]

0 commit comments

Comments
 (0)