Skip to content

Conversation

emmanuel-ferdman
Copy link
Contributor

PR Summary

This small PR fixes the renames the duplicated test method for config parsing.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@ckirsch
Copy link
Member

ckirsch commented Jun 23, 2025

@emmanuel-ferdman what is the purpose of this change?

@emmanuel-ferdman
Copy link
Contributor Author

@ckirsch The purpose of this change is to address an issue where there are two distinct test methods defined with the exact same name: test_invalid_command_placement. In Python, when you define multiple methods with the same name within a single class, the last definition overwrites any previous ones. As a result, only the second test (the one intended to check invalid_format_cfg) was actually being discovered and executed by the test runner. The first test (intended to check invalid_command_placement_cfg) was silent and never ran, potentially hiding a bug or a gap in the test coverage for that specific scenario.

@ckirsch ckirsch merged commit c838cfe into cksystemsteaching:main Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants