Skip to content

Commit ab8f466

Browse files
authored
Make utility classes proper utilities
1 parent 43d8e9a commit ab8f466

File tree

11 files changed

+28
-11
lines changed

11 files changed

+28
-11
lines changed

cloudinary-core/src/main/java/com/cloudinary/SmartUrlEncoder.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
import java.io.UnsupportedEncodingException;
44
import java.net.URLEncoder;
55

6-
public class SmartUrlEncoder {
6+
public final class SmartUrlEncoder {
7+
private SmartUrlEncoder() {}
8+
79
public static String encode(String input) {
810
try {
911
return URLEncoder.encode(input, "UTF-8").replace("%2F", "/").replace("%3A", ":").replace("+", "%20");

cloudinary-core/src/main/java/com/cloudinary/Util.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88
import java.security.NoSuchAlgorithmException;
99
import java.util.*;
1010

11-
public class Util {
11+
public final class Util {
12+
private Util() {}
13+
1214
static final String[] BOOLEAN_UPLOAD_OPTIONS = new String[]{"backup", "exif", "faces", "colors", "image_metadata", "use_filename", "unique_filename",
1315
"eager_async", "invalidate", "discard_original_filename", "overwrite", "phash", "return_delete_token", "async", "quality_analysis", "cinemagraph_analysis",
1416
"accessibility_analysis", "use_filename_as_display_name", "use_asset_folder_as_public_id_prefix", "unique_display_name", "media_metadata", "visual_search",

cloudinary-core/src/main/java/com/cloudinary/utils/Base64Map.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
import java.util.HashMap;
44
import java.util.Map;
55

6-
public class Base64Map {
6+
public final class Base64Map {
7+
private Base64Map() {}
8+
79
public static Map<String, String> values;
810

911
static {

cloudinary-core/src/main/java/com/cloudinary/utils/HtmlEscape.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616
* this program code.
1717
*/
1818

19-
public class HtmlEscape {
19+
public final class HtmlEscape {
20+
private HtmlEscape() {}
2021

2122
private static char[] hex = {'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f'};
2223

cloudinary-core/src/main/java/com/cloudinary/utils/ObjectUtils.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
import java.util.*;
1212

1313

14-
public class ObjectUtils {
14+
public final class ObjectUtils {
15+
private ObjectUtils() {}
16+
1517
/**
1618
* Formats a Date as an ISO-8601 string representation.
1719
* @param date Date to format

cloudinary-core/src/main/java/com/cloudinary/utils/StringUtils.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88
import java.util.regex.Matcher;
99
import java.util.regex.Pattern;
1010

11-
public class StringUtils {
11+
public final class StringUtils {
12+
private StringUtils() {}
13+
1214
public static final String EMPTY = "";
1315

1416
/**

cloudinary-http5/src/main/java/com/cloudinary/http5/ApiUtils.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010

1111
import java.util.*;
1212

13-
public class ApiUtils {
13+
public final class ApiUtils {
14+
private ApiUtils() {}
1415

1516
public static void setTimeouts(HttpUriRequestBase request, Map<String, ? extends Object> options) {
1617
RequestConfig config = request.getConfig();

cloudinary-taglib/src/main/java/com/cloudinary/Singleton.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
*
1111
* @author jpollak
1212
*/
13-
public class Singleton {
13+
public final class Singleton {
14+
private Singleton() {}
1415

1516
private static Cloudinary cloudinary;
1617

cloudinary-test-common/src/main/java/com/cloudinary/test/AbstractApiTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,7 @@ public void testRateLimits() throws Exception {
670670

671671
@Test
672672
public void testConfiguration() throws Exception {
673-
ApiResponse result = cloudinary.api().configuration(new ObjectUtils().asMap("settings", true));
673+
ApiResponse result = cloudinary.api().configuration(ObjectUtils.asMap("settings", true));
674674
Map settings = (Map) result.get("settings");
675675
Assert.assertNotNull(settings.get("folder_mode"));
676676
}

cloudinary-test-common/src/main/java/com/cloudinary/test/MetadataTestHelper.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
import com.cloudinary.metadata.MetadataValidation;
77
import com.cloudinary.metadata.StringMetadataField;
88

9-
public class MetadataTestHelper {
9+
public final class MetadataTestHelper {
10+
private MetadataTestHelper() {}
11+
1012
public static StringMetadataField newFieldInstance(String label, Boolean mandatory) throws Exception {
1113
StringMetadataField field = new StringMetadataField();
1214
field.setLabel(label);

0 commit comments

Comments
 (0)