QUA-218: Use streams to stringify large jsons #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-moya
reviewed
Apr 27, 2021
| var issueJson = buildIssueJson(message, path) | ||
| STDOUT(issueJson + "\u0000\n") | ||
| var readableJsonStream = buildIssueJson(message, path) | ||
| var output = "" |
There was a problem hiding this comment.
Shouldn't instead be like follows ?
var output = ""
readableJsonStream.on('data', (chunk) => {
output = output + chunk
})
readableJsonStream.on('end', () => process.stdout.write(`${JSON.stringify(output)}` + "\u0000\n"))There was a problem hiding this comment.
We want to avoid applying stringify on large jsons, that's why it's applied on the chunks, building the string little by little. Does it make sense?
f-moya
approved these changes
Apr 27, 2021
|
@noelia-lencina - ready to merge? |
|
@noelia-lencina to fix tests |
|
UPDATE I followed Noe's advice and I converted the failing integration tests into system tests. The integration tests were failing because they used to depend too much on implementation details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://codeclimate.atlassian.net/browse/QUA-218
This intends to process issues as a stream, to avoid passing a large json to
JSON.stringify, which may cause memory problems.