Use ruleset.xml by default if present #18

filipesperandio · 2017-09-25T14:51:42Z

No description provided.

toddmazierski · 2017-09-25T17:08:05Z

src/Config.groovy

@@ -34,6 +34,11 @@ class Config {
      }
    }

+    def prjRulesByConvention = new File(appContext.codeFolder, "ruleset.xml")


Is prj an abbreviation for project? Is it a common one in Groovy? If not, I'd suggest using the full word instead.

toddmazierski · 2017-09-25T17:10:16Z

test/ConfigTest.groovy

+
+  @Test
+  public void honorPresentRules() {
+    def config = new Config([configFile: "/usr/src/app/fixtures/config.json", codeFolder: "/usr/src/app/fixtures/honor"])


What does the name /honor mean in the path? Is this a fixture directory just for this test?

If yes, I might suggest something more explicit like /ruleset_default, and maybe moving specified_rules.xml and config.rule.json to something like /ruleset_specified.

@toddmazierski Re-structured fixture directory. Do you mind giving another shot?

filipesperandio · 2017-09-25T18:21:04Z

@toddmazierski I liked your suggestion about the fixtures, the final structure is much easier to understand:

fixtures/
├── bad_config
│   ├── Main.java
│   └── config.json
├── default
│   ├── Main.java
│   └── config.json
├── ruleset_default_file
│   ├── Main.java
│   ├── config.json
│   └── ruleset.xml
└── specified_file
    ├── Main.java
    ├── config.new.json
    ├── config.old.json
    └── rules.xml

toddmazierski

Rock on. Thanks for considering those suggestions. 🚀

Use ruleset.xml by default if present

5bb0240

codeclimate-hermes assigned toddmazierski Sep 25, 2017

filipesperandio requested a review from wilson September 25, 2017 14:56

toddmazierski reviewed Sep 25, 2017

View reviewed changes

filipesperandio added 3 commits September 25, 2017 15:15

Re-structure fixtures by directory

bf2db0d

Improve naming

2c446cb

Remove leftover

18d2f37

toddmazierski approved these changes Sep 25, 2017

View reviewed changes

filipesperandio merged commit 01c813b into master Sep 25, 2017

filipesperandio deleted the fe/standard_rules_file branch September 25, 2017 18:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ruleset.xml by default if present #18

Use ruleset.xml by default if present #18

filipesperandio commented Sep 25, 2017

toddmazierski Sep 25, 2017

toddmazierski Sep 25, 2017

filipesperandio Sep 25, 2017

filipesperandio commented Sep 25, 2017

toddmazierski left a comment

Use ruleset.xml by default if present #18

Use ruleset.xml by default if present #18

Conversation

filipesperandio commented Sep 25, 2017

toddmazierski Sep 25, 2017

Choose a reason for hiding this comment

toddmazierski Sep 25, 2017

Choose a reason for hiding this comment

filipesperandio Sep 25, 2017

Choose a reason for hiding this comment

filipesperandio commented Sep 25, 2017

toddmazierski left a comment

Choose a reason for hiding this comment