Skip to content

Update reference to xsd #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KroArtem
Copy link

@KroArtem KroArtem commented Jan 4, 2021

Update reference to xsd as it is stated in https://pmd.github.io/latest/pmd_userdocs_making_rulesets.html

@KroArtem
Copy link
Author

KroArtem commented Jan 4, 2021

Also ping @larkinscott

@KroArtem
Copy link
Author

@filipesperandio , @larkinscott , hello there, may I kindly ask you to review this MR and #34 ? As far as I understand, it's required to have newer pmd in codeclimate that will allow to use it in gitlab codeclimate. (after releasing new version of codeclimate).

@filipesperandio filipesperandio changed the base branch from master to channel/beta January 11, 2021 15:09
@filipesperandio
Copy link
Contributor

@KroArtem thanks for the help here.
Since it is being a while we don't change things in this repo, I'm tending to ship things to the channel/beta branch first so we can manage its rollout to a subset of the users.

I've updated the base branch for the PR, do you mind rebasing it with channel/beta? I can merge it in right after.

@KroArtem KroArtem force-pushed the update-reference-to-xsd branch from a2ef2af to 7362e8d Compare January 13, 2021 22:33
@KroArtem
Copy link
Author

@filipesperandio, done

@filipesperandio filipesperandio merged commit 9c6f77d into codeclimate:channel/beta Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants