Capture stdout not in json format and raise error #9

filipesperandio · 2017-09-13T16:02:41Z

Errors like this:

$ codeclimate analyze
Starting analysis
Running pmd: Done!
error: (JSON::ParserError) 743: unexpected token at 'Removed misconfigured rule: LoosePackageCoupling  cause: No packages or classes specified '

Become:

$ codeclimate analyze
Starting analysis
Running pmd: Done!
error: (CC::Analyzer::Engine::EngineFailure) engine pmd:beta failed with status 255 and stderr
Removed misconfigured rule: LoosePackageCoupling  cause: No packages or classes specified

wfleming · 2017-09-13T16:43:07Z

pmd.groovy

+    System.out.println(line)
+  } else {
+    System.err.println(line)
+    System.exit(-1)


Might be overly aggressive: it looks like the motivating example here was clearly a log line, and not intended to be an issue. Should we just shunt all these lines to stderr & keep processing?

Optimally we'd like all engines to separate their output streams upstream, but I don't know how feasible that is in this case.

@wfleming Yeah, I think it makes sense to redirect those non-issues entries and not abort. I worry a bit about unknown scenarios, though.

@wfleming The problem I see in the CLI is that the user will only have a clue about this warning if CODECLIMATE_DEBUG is on.

…sing" This reverts commit 5c53e71.

Capture stdout not in json format and raise error

e418aef

filipesperandio requested a review from codeclimate-hermes September 13, 2017 16:02

codeclimate-hermes requested review from ale7714 and removed request for codeclimate-hermes September 13, 2017 16:02

wfleming approved these changes Sep 13, 2017

View reviewed changes

filipesperandio added 2 commits September 13, 2017 16:49

Redirect bad output (e.g. warnings) to stderr but keep processing

5c53e71

Revert "Redirect bad output (e.g. warnings) to stderr but keep proces…

69d110b

…sing" This reverts commit 5c53e71.

filipesperandio merged commit 4dc16a6 into master Sep 13, 2017

filipesperandio deleted the fe/handles_bad_output branch September 13, 2017 21:10

filipesperandio mentioned this pull request Sep 13, 2017

Redirect bad output (e.g. warnings) to stderr but keep processing #12

Closed

filipesperandio added a commit that referenced this pull request Sep 14, 2017

Capture stdout not in json format and raise error (#9)

a071578

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Capture stdout not in json format and raise error #9

Capture stdout not in json format and raise error #9

filipesperandio commented Sep 13, 2017

wfleming Sep 13, 2017

filipesperandio Sep 13, 2017

filipesperandio Sep 13, 2017

Capture stdout not in json format and raise error #9

Capture stdout not in json format and raise error #9

Conversation

filipesperandio commented Sep 13, 2017

wfleming Sep 13, 2017

Choose a reason for hiding this comment

filipesperandio Sep 13, 2017

Choose a reason for hiding this comment

filipesperandio Sep 13, 2017

Choose a reason for hiding this comment