Upgrade libs (#39)

* Upgrade java plugin

* Upgrade sonar libs and adjust interfaces

Author: filipesperandio

build.gradle

@@ -32,14 +32,13 @@ build.dependsOn(infra)
 test.dependsOn(infra)
 
 dependencies {
-    compile("org.sonarsource.sonarlint.core:sonarlint-core:2.10.0.367")
-    compile("org.sonarsource.sonarlint.core:sonarlint-client-api:2.10.0.367")
+    compile("org.sonarsource.sonarlint.core:sonarlint-core:2.17.0.899")
+    compile("org.sonarsource.sonarlint.core:sonarlint-client-api:2.17.0.899")
     compile("org.sonarsource.sonarlint:sonarlint-cli:2.1.0.566")
-    compile("com.google.code.gson:gson:2.6.2")
-
+    compile("com.google.code.gson:gson:2.8.2")
 
     // Plugins
-    compile("org.sonarsource.java:sonar-java-plugin:4.3.0.7717")
+    compile("org.sonarsource.java:sonar-java-plugin:4.14.0.11784")
 
     testCompile("org.assertj:assertj-core:2.8.0")
     testCompile("org.skyscreamer:jsonassert:1.5.0")

src/main/java/cc/analysis/SonarLintFactory.java

@@ -11,7 +11,6 @@
 import java.nio.file.Path;
 
 public class SonarLintFactory extends org.sonarlint.cli.analysis.SonarLintFactoryWrapper {
-    private static final Logger LOGGER = Logger.get();
     private Path workDir;
 
     public SonarLintFactory(ConfigurationReader reader, Path workDir) {
@@ -21,14 +20,14 @@ public SonarLintFactory(ConfigurationReader reader, Path workDir) {
 
     @Override
     public SonarLint createSonarLint(Path projectHome, boolean mustBeConnected, boolean verbose) {
-        LOGGER.info("Standalone mode");
+        LogOutputWrapper logWrapper = new LogOutputWrapper(verbose);
 
         StandaloneGlobalConfiguration config = StandaloneGlobalConfiguration.builder()
                 .addPlugins(plugins())
-                .setLogOutput(new LogOutputWrapper(LOGGER, verbose))
+                .setLogOutput(logWrapper)
                 .build();
 
         StandaloneSonarLintEngine engine = new StandaloneSonarLintEngineImpl(config);
-        return new StandaloneSonarLint(engine, workDir);
+        return new StandaloneSonarLint(engine, workDir, logWrapper);
     }
 }

src/main/java/cc/analysis/StandaloneSonarLint.java

@@ -1,7 +1,9 @@
 package cc.analysis;
 
 import org.sonarlint.cli.analysis.IssueCollector;
+import org.sonarlint.cli.analysis.LogOutputWrapper;
 import org.sonarlint.cli.report.ReportFactory;
+import org.sonarsource.sonarlint.core.client.api.common.ProgressMonitor;
 import org.sonarsource.sonarlint.core.client.api.common.analysis.AnalysisResults;
 import org.sonarsource.sonarlint.core.client.api.common.analysis.ClientInputFile;
 import org.sonarsource.sonarlint.core.client.api.standalone.StandaloneAnalysisConfiguration;
@@ -19,11 +21,13 @@
 public class StandaloneSonarLint extends org.sonarlint.cli.analysis.StandaloneSonarLint {
     private StandaloneSonarLintEngine engine;
     private Path workDir;
+    private LogOutputWrapper logWrapper;
 
-    public StandaloneSonarLint(StandaloneSonarLintEngine engine, Path workDir) {
+    public StandaloneSonarLint(StandaloneSonarLintEngine engine, Path workDir, LogOutputWrapper logWrapper) {
         super(engine);
         this.engine = engine;
         this.workDir = workDir;
+        this.logWrapper = logWrapper;
     }
 
     @Override
@@ -32,8 +36,11 @@ protected void doAnalysis(Map<String, String> properties, ReportFactory reportFa
 
         IssueCollector collector = new IssueCollector();
         StandaloneAnalysisConfiguration config = new StandaloneAnalysisConfiguration(baseDirPath, workDir, inputFiles, properties);
-        AnalysisResults result = engine.analyze(config, collector);
+        AnalysisResults result = engine.analyze(config, collector, logWrapper, new NoOpProgressMonitor());
         Collection<Trackable> trackables = collector.get().stream().map(IssueTrackable::new).collect(Collectors.toList());
         generateReports(trackables, result, reportFactory, baseDirPath.getFileName().toString(), baseDirPath, start);
     }
+
+    private static class NoOpProgressMonitor extends ProgressMonitor {
+    }
 }

src/main/java/org/sonarlint/cli/analysis/LogOutputWrapper.java

@@ -3,7 +3,8 @@
 import org.sonarlint.cli.util.Logger;
 
 public class LogOutputWrapper extends DefaultLogOutput {
-    public LogOutputWrapper(Logger logger, boolean verbose) {
-        super(logger, verbose);
+
+    public LogOutputWrapper(boolean verbose) {
+        super(Logger.get(), verbose);
     }
 }

src/test/java/support/fakes/FakeTrackable.java

@@ -39,6 +39,12 @@ public String getMessage() {
         return null;
     }
 
+    @CheckForNull
+    @Override
+    public String getType() {
+        return null;
+    }
+
     @CheckForNull
     @Override
     public Integer getLine() {

src/test/resources/sanity_check_expected_issues.json

@@ -3,7 +3,7 @@
     "type": "issue",
     "check_name": "squid:S106",
     "severity": "major",
-    "description": "Replace this usage of System.out or System.err by a logger.",
+    "description": "Replace this use of System.out or System.err by a logger.",
     "content": {
       "body": "<p>When logging a message there are several important requirements which must be fulfilled:</p>\n<ul>\n  <li> The user must be able to easily retrieve the logs </li>\n  <li> The format of all logged message must be uniform to allow the user to easily read the log </li>\n  <li> Logged data must actually be recorded </li>\n  <li> Sensitive data must only be logged securely </li>\n</ul>\n<p>If a program directly writes to the standard outputs, there is absolutely no way to comply with those requirements. That's why defining and using a\ndedicated logger is highly recommended.</p>\n<h2>Noncompliant Code Example</h2>\n<pre>\nSystem.out.println(\"My Message\");  // Noncompliant\n</pre>\n<h2>Compliant Solution</h2>\n<pre>\nlogger.log(\"My Message\");\n</pre>\n<h2>See</h2>\n<ul>\n  <li> <a href=\"https://www.securecoding.cert.org/confluence/x/RoElAQ\">CERT, ERR02-J.</a> - Prevent exceptions while logging data </li>\n</ul>"
     },
@@ -58,7 +58,7 @@
     "severity": "critical",
     "description": "Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.",
     "content": {
-      "body": "<p>There are several reasons for a method not to have a method body:</p>\n<ul>\n  <li> It is an unintentional omission, and should be fixed to prevent an unexpected behavior in production. </li>\n  <li> It is not yet, or never will be, supported. In this case an <code>UnsupportedOperationException</code> should be thrown. </li>\n  <li> The method is an intentionally-blank override. In this case a nested comment should explain the reason for the blank override. </li>\n  <li> There is a desire to provide a public, no-args constructor. In this case, it can simply be omitted from the code; a default constructor will\n  automatically be generated. </li>\n</ul>\n<h2>Noncompliant Code Example</h2>\n<pre>\npublic void doSomething() {\n}\n\npublic void doSomethingElse() {\n}\n</pre>\n<h2>Compliant Solution</h2>\n<pre>\n@Override\npublic void doSomething() {\n  // Do nothing because of X and Y.\n}\n\n@Override\npublic void doSomethingElse() {\n  throw new UnsupportedOperationException();\n}\n</pre>\n<h2>Exceptions</h2>\n<p>An abstract class may have empty methods, in order to provide default implementations for child classes.</p>\n<pre>\npublic abstract class Animal {\n  void speak() {\n  }\n}\n</pre>"
+      "body": "<p>There are several reasons for a method not to have a method body:</p>\n<ul>\n  <li> It is an unintentional omission, and should be fixed to prevent an unexpected behavior in production. </li>\n  <li> It is not yet, or never will be, supported. In this case an <code>UnsupportedOperationException</code> should be thrown. </li>\n  <li> The method is an intentionally-blank override. In this case a nested comment should explain the reason for the blank override. </li>\n</ul>\n<h2>Noncompliant Code Example</h2>\n<pre>\npublic void doSomething() {\n}\n\npublic void doSomethingElse() {\n}\n</pre>\n<h2>Compliant Solution</h2>\n<pre>\n@Override\npublic void doSomething() {\n  // Do nothing because of X and Y.\n}\n\n@Override\npublic void doSomethingElse() {\n  throw new UnsupportedOperationException();\n}\n</pre>\n<h2>Exceptions</h2>\n<p>Default (no-argument) constructors are ignored when there are other constructors in the class, as are empty methods in abstract classes.</p>\n<pre>\npublic abstract class Animal {\n  void speak() {  // default implementation ignored\n  }\n}\n</pre>"
     },
     "location": {
       "path": "main/java/Library.java",