Find correct paths to process #21
Conversation
filipesperandio
force-pushed
the
fe/finder
branch
2 times, most recently
from
8d6f747 to
b2dcf86
Compare
filipesperandio
force-pushed
the
fe/finder
branch
from
b2dcf86 to
f2cbbc6
Compare
codeclimate-hermes
requested review from
wfleming
and removed request for
codeclimate-hermes
src/main/java/cc/files/Matcher.java
Outdated
| return defaultMatcher; | ||
| } | ||
| } catch (Exception e) { | ||
| throw new RuntimeException("Error creating create with pattern: " + pattern, e); |
There was a problem hiding this comment.
Should this be Error creating matcher?
src/main/java/cc/files/Finder.java
Outdated
| public List<ClientInputFile> collect(Path baseDir) throws IOException { | ||
| return findPaths(baseDir).stream() | ||
| .map(p -> toClientInputFile(baseDir, p)) | ||
| .filter(f -> f != null) |
There was a problem hiding this comment.
What do you think of expanding these single letter variables out? Not sure what's p stands for. Is f for file?
There was a problem hiding this comment.
@dblandin p expanded to path.
f != null replaced with Objects::nonull ;)
Ready for another shot?
|
This ship may have sailed, but why does this engine need to concern itself with glob matching, and what's "source" vs "tests"? The CLI should expand globs and determine appropriate concrete |
|
@wfleming Ship still on shore. Looking at the code again, I probably made this distinction a bit clear on another branch - not sure why I haven't brought it over. I will do so, it basically gets rid of the |
|
@wfleming No |
The file count is a bit extensive, but one can skip the
fixturesfiles during the review to speed it up.Related to #12 and #15