Skip to content

Allow configuration overrides #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 13, 2017
Prev Previous commit
Next Next commit
No need for exclusion patterns
  • Loading branch information
filipesperandio committed Oct 12, 2017
commit 01c8e658fcc757844223662b891ab4eb0b51a5ac
5 changes: 0 additions & 5 deletions src/main/java/cc/Config.java
Original file line number Diff line number Diff line change
@@ -16,7 +16,6 @@ public class Config {
private class EngineConfig {
public String charset;
public List<String> testsPatterns;
public List<String> exclusionPatterns;
}

public List<String> getIncludePaths() {
@@ -31,10 +30,6 @@ public String getTestsPatterns() {
return joinPatterns(config.testsPatterns);
}

public String getExclusionPatterns() {
return joinPatterns(config.exclusionPatterns);
}

private String joinPatterns(List<String> patterns) {
if (patterns == null) {
return null;
6 changes: 0 additions & 6 deletions src/test/java/cc/ConfigTest.java
Original file line number Diff line number Diff line change
@@ -29,10 +29,4 @@ public void fetch_tests_patterns() throws Exception {
Config config = Config.gson().fromJson("{\"config\":{\"tests_patterns\":[\"src/test/**\",\"src/test2/**\"]}}", Config.class);
assertThat(config.getTestsPatterns()).isEqualTo("{src/test/**,src/test2/**}");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a test case for when tests_patterns is null (or missing) in the configuration file?

}

@Test
public void fetch_exclusion_patterns() throws Exception {
Config config = Config.gson().fromJson("{\"config\":{\"exclusion_patterns\":[\"src/excluded/**\",\"src/test2/**\"]}}", Config.class);
assertThat(config.getExclusionPatterns()).isEqualTo("{src/excluded/**,src/test2/**}");
}
}