feat: add ability to read new file format #1260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Sentry found no issues in your recent changes ✅ |
joseph-sentry
force-pushed
the
joseph/file-format
branch
from
91f65de to
d84eaab
Compare
joseph-sentry
force-pushed
the
joseph/file-format
branch
from
d84eaab to
dba1525
Compare
Swatinem
approved these changes
Apr 2, 2025
docker-compose.yml
Outdated
| image: minio/minio:latest | ||
| command: server /export | ||
| ports: | ||
| - "${MINIO_PORT:-9000}:9000" |
There was a problem hiding this comment.
I noticed recently that shared/worker are conflicting with each other, as they are exposing this port to the host. we don’t need this in order to run tests, so I would just not do this.
i'm introducing 2 things here:
- the ability to read the output of the new ta cache rollups code in
the new location in GCS
- the ability to read multiple versions of the new rollup file
- its probable that the "no version" file never exists in prod GCS
but i'd like to establish this pattern in the code nonetheless
i also add metrics
joseph-sentry
force-pushed
the
joseph/file-format
branch
from
dba1525 to
2b2e69b
Compare
i'm introducing 2 things here:
- the ability to read the output of the new ta cache rollups code in
the new location in GCS
- the ability to read multiple versions of the new rollup file
- its probable that the "no version" file never exists in prod GCS
but i'd like to establish this pattern in the code nonetheless
i also add metrics
joseph-sentry
force-pushed
the
joseph/file-format
branch
from
2b2e69b to
a5e0d4e
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1260 +/- ##
==========================================
- Coverage 96.31% 96.29% -0.03%
==========================================
Files 487 487
Lines 16891 16940 +49
==========================================
+ Hits 16269 16312 +43
- Misses 622 628 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Swatinem
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i'm introducing 2 things here:
the new location in GCS
but i'd like to establish this pattern in the code nonetheless
i also add metrics