-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rename Okta redirect URI -> Okta Base URL #3828
Conversation
✅ Sentry found no issues in your recent changes ✅ |
Bundle ReportChanges will decrease total bundle size by 58 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3828 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 827 827
Lines 15000 15000
Branches 4281 4281
=======================================
Hits 14809 14809
Misses 184 184
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3828 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 827 827
Lines 15000 15000
Branches 4289 4289
=======================================
Hits 14809 14809
Misses 184 184
Partials 7 7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3828 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 827 827
Lines 15000 15000
Branches 4281 4289 +8
=======================================
Hits 14809 14809
Misses 184 184
Partials 7 7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Bundle ReportChanges will decrease total bundle size by 58 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3828 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 827 827
Lines 15000 15000
Branches 4289 4281 -8
=======================================
Hits 14809 14809
Misses 184 184
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Did we move away from calling it "Okta base URL" based on vlad's note on the ticket? |
Yes |
But I did just notice that vlad suggested Okta base URL and not redirect URL... my bad 😂 |
was a race condition in the test. Made it deterministic. |
73347a3
to
2b35997
Compare
c6848c5
to
ebd13df
Compare
ebd13df
to
8aa7db8
Compare
Renames Okta redirect URI to Okta Base URL.
Closes codecov/feedback#517