Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename Okta redirect URI -> Okta Base URL #3828

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

spalmurray
Copy link
Contributor

@spalmurray spalmurray commented Mar 26, 2025

Renames Okta redirect URI to Okta Base URL.

Closes codecov/feedback#517

Copy link
Contributor

✅ Sentry found no issues in your recent changes ✅

@codecov-staging
Copy link

codecov-staging bot commented Mar 26, 2025

Bundle Report

Changes will decrease total bundle size by 58 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.22MB -29 bytes (-0.0%) ⬇️
gazebo-staging-esm 6.29MB -29 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -29 bytes 7.4kB -0.39%

Files in assets/index-legacy.*.js:

  • ./src/pages/AccountSettings/tabs/OktaAccess/OktaConfigForm/OktaConfigForm.tsx → Total Size: 8.83kB
view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -29 bytes 7.45kB -0.39%

Files in assets/index.*.js:

  • ./src/pages/AccountSettings/tabs/OktaAccess/OktaConfigForm/OktaConfigForm.tsx → Total Size: 8.83kB

@codecov-staging
Copy link

codecov-staging bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3828   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15000    15000           
  Branches     4281     4281           
=======================================
  Hits        14809    14809           
  Misses        184      184           
  Partials        7        7           
Files with missing lines Coverage Δ
.../tabs/OktaAccess/OktaConfigForm/OktaConfigForm.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.28% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f33b4...ba6daa0. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (30f33b4) to head (ba6daa0).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3828   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15000    15000           
  Branches     4289     4289           
=======================================
  Hits        14809    14809           
  Misses        184      184           
  Partials        7        7           
Files with missing lines Coverage Δ
.../tabs/OktaAccess/OktaConfigForm/OktaConfigForm.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.28% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f33b4...ba6daa0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codecov-public-qa bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (30f33b4) to head (ba6daa0).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3828   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15000    15000           
  Branches     4281     4289    +8     
=======================================
  Hits        14809    14809           
  Misses        184      184           
  Partials        7        7           
Files with missing lines Coverage Δ
.../tabs/OktaAccess/OktaConfigForm/OktaConfigForm.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.28% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f33b4...ba6daa0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codecov bot commented Mar 26, 2025

Bundle Report

Changes will decrease total bundle size by 58 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.22MB -29 bytes (-0.0%) ⬇️
gazebo-production-esm 6.29MB -29 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index.*.js -29 bytes 7.45kB -0.39%

Files in assets/index.*.js:

  • ./src/pages/AccountSettings/tabs/OktaAccess/OktaConfigForm/OktaConfigForm.tsx → Total Size: 8.83kB
view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-legacy.*.js -29 bytes 7.4kB -0.39%

Files in assets/index-legacy.*.js:

  • ./src/pages/AccountSettings/tabs/OktaAccess/OktaConfigForm/OktaConfigForm.tsx → Total Size: 8.83kB

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 26, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
0d7ea2c Wed, 26 Mar 2025 15:44:09 GMT Expired Expired
f183ef1 Wed, 26 Mar 2025 18:16:33 GMT Expired Expired
2b35997 Wed, 26 Mar 2025 21:45:55 GMT Expired Expired
73347a3 Wed, 26 Mar 2025 22:29:06 GMT Expired Expired
73347a3 Wed, 26 Mar 2025 22:32:43 GMT Expired Expired
2b35997 Thu, 27 Mar 2025 00:21:43 GMT Expired Expired
df1bc32 Thu, 27 Mar 2025 22:13:20 GMT Expired Expired
1ff3c00 Tue, 01 Apr 2025 19:24:01 GMT Expired Expired
c6848c5 Tue, 01 Apr 2025 19:48:19 GMT Expired Expired
ebd13df Thu, 03 Apr 2025 13:44:40 GMT Expired Expired
8aa7db8 Fri, 04 Apr 2025 14:34:42 GMT Expired Expired
ba6daa0 Wed, 09 Apr 2025 14:02:17 GMT Cloud Enterprise

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (30f33b4) to head (ba6daa0).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3828   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         827      827           
  Lines       15000    15000           
  Branches     4289     4281    -8     
=======================================
  Hits        14809    14809           
  Misses        184      184           
  Partials        7        7           
Files with missing lines Coverage Δ
.../tabs/OktaAccess/OktaConfigForm/OktaConfigForm.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.28% <ø> (ø)
Services 99.35% <ø> (ø)
Shared 99.11% <ø> (ø)
UI 99.15% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f33b4...ba6daa0. Read the comment docs.

@spalmurray spalmurray marked this pull request as ready for review March 26, 2025 17:20
@calvin-codecov
Copy link
Contributor

Did we move away from calling it "Okta base URL" based on vlad's note on the ticket?

@spalmurray
Copy link
Contributor Author

Yes

@spalmurray
Copy link
Contributor Author

But I did just notice that vlad suggested Okta base URL and not redirect URL... my bad 😂

@calvin-codecov calvin-codecov self-requested a review March 26, 2025 18:14
@spalmurray spalmurray changed the title chore: Rename Okta redirect URI -> URL chore: Rename Okta redirect URI -> Okta Base URL Mar 26, 2025
@spalmurray
Copy link
Contributor Author

was a race condition in the test. Made it deterministic.

@spalmurray spalmurray force-pushed the spalmurray/oktaredirecturitourl branch from 73347a3 to 2b35997 Compare March 27, 2025 00:16
@spalmurray spalmurray added this pull request to the merge queue Apr 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 1, 2025
@spalmurray spalmurray added this pull request to the merge queue Apr 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 1, 2025
@spalmurray spalmurray added this pull request to the merge queue Apr 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 1, 2025
@spalmurray spalmurray force-pushed the spalmurray/oktaredirecturitourl branch from c6848c5 to ebd13df Compare April 3, 2025 13:39
@spalmurray spalmurray force-pushed the spalmurray/oktaredirecturitourl branch from ebd13df to 8aa7db8 Compare April 4, 2025 14:26
@spalmurray spalmurray added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit c64253b Apr 9, 2025
63 checks passed
@spalmurray spalmurray deleted the spalmurray/oktaredirecturitourl branch April 9, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the Okta URI field in the Codecov UI to make it more clear
3 participants