Skip to content

proxy: Drop double-wrapping in RequestInitiationError #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

cgwalters
Copy link
Collaborator

See bootc-dev/bootc#1284 - the error text is

ERROR Upgrading: Creating importer: failed to invoke method OpenImage: failed to invoke method OpenImage: lstat ...

This fixes the duplication of failed to invoke method OpenImage.

I think this was a regression from porting to use thiserror when I was changing the type of each individual function to return our Result type.

See bootc-dev/bootc#1284 - the error
text is

`ERROR Upgrading: Creating importer: failed to invoke method OpenImage: failed to invoke method OpenImage: lstat ...`

This fixes the duplication of `failed to invoke method OpenImage`.

I think this was a regression from porting to use thiserror when
I was changing the type of each individual function to return our
Result type.

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Collaborator

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeckersb jeckersb merged commit e8c8c90 into containers:main May 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants