Skip to content

Restrict number of concurrently repaired hosted packages #4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 32 additions & 23 deletions lib/src/source/hosted.dart
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@ import 'package:crypto/crypto.dart';
import 'package:http/http.dart' as http;
import 'package:meta/meta.dart';
import 'package:path/path.dart' as p;
import 'package:pool/pool.dart';
import 'package:pub_semver/pub_semver.dart';
import 'package:stack_trace/stack_trace.dart';

@@ -1348,32 +1349,40 @@ class HostedSource extends CachedSource {

packages.sort(Package.orderByNameAndVersion);

final pool = Pool(10);
return results..addAll(
await Future.wait(
packages.map((package) async {
final id = PackageId(
package.name,
package.version,
ResolvedHostedDescription(
HostedDescription._(package.name, url),
sha256: null,
),
);
try {
deleteEntry(package.dir);
await _download(id, package.dir, cache);
return RepairResult(id.name, id.version, this, success: true);
} catch (error, stackTrace) {
var message =
'Failed to repair ${log.bold(package.name)} '
'${package.version}';
if (url != defaultUrl) message += ' from $url';
log.error('$message. Error:\n$error');
log.fine(stackTrace.toString());

tryDeleteEntry(package.dir);
return RepairResult(id.name, id.version, this, success: false);
}
return await pool.withResource(() async {
final id = PackageId(
package.name,
package.version,
ResolvedHostedDescription(
HostedDescription._(package.name, url),
sha256: null,
),
);
try {
deleteEntry(package.dir);
await _download(id, package.dir, cache);
return RepairResult(id.name, id.version, this, success: true);
} catch (error, stackTrace) {
var message =
'Failed to repair ${log.bold(package.name)} '
'${package.version}';
if (url != defaultUrl) message += ' from $url';
log.error('$message. Error:\n$error');
log.fine(stackTrace.toString());

tryDeleteEntry(package.dir);
return RepairResult(
id.name,
id.version,
this,
success: false,
);
}
});
}),
),
);