Skip to content

fix[engine]: add info to use bash -i for non posix shells #21790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AyushSehrawat
Copy link

Description

The docker engine install commands for debian and related distros depended on bash scripting which didn't work well with non-posix shells like fish. This PR aims to solve it.

I have added alerts to use bash -i before running those commands. bash -i starts an interactive bash shell

Related issues or tickets

#20285

Reviews

@thaJeztah

  • Technical review
  • Editorial review
  • Product review

@AyushSehrawat AyushSehrawat requested a review from dvdksn as a code owner January 11, 2025 17:26
@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/install Relates to installing a product labels Jan 11, 2025
Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 1f22ebb
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6782a9e21beb8a000825e984
😎 Deploy Preview https://deploy-preview-21790--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn requested a review from thaJeztah January 13, 2025 08:22
@docker-robot
Copy link

docker-robot bot commented Apr 13, 2025

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

@AyushSehrawat
Copy link
Author

/lifecycle frozen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issue affects Docker engine/daemon area/install Relates to installing a product lifecycle/frozen lifecycle/stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant