-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENGDOCS-2515a #22357
ENGDOCS-2515a #22357
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
## Integrated terminal | ||
|
||
From the Docker Dashboard footer, you can use the integrated terminal, on a running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like 2 different features got mixed in together. The terminal at the footer is different than the terminal in the container detail view in the Exec or Debug tab (or via the action menu).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have made clearer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Subjectively, I still think the features are mixed together, while having big differences that aren't clear.
They're both integrated terminals, but they have different entry points and different use-cases. The one at the footer opens in the host. The one in debug/exec/action menu opens in a container.
For example:
Using the integrated terminal is the same as running one of the following commands:
docker exec -it <container-id> /bin/sh
docker exec -it <container-id> cmd.exe when accessing Windows containers
docker debug <container-id> when using debug mode
The integrated terminal:
Persists your session if you navigate to another part of the Docker Desktop Dashboard and then return.
Supports copy, paste, search, and clearing your session.
Automatically detects the default user for a running container from the image's Dockerfile. If no user is specified, or you're using debug mode, it defaults to root.
None of that, except the persist and copy parts, applies to the terminal at the footer. Users can run docker exec
in the footer terminal, but it's not the default entry point.
I see where I was going wrong @craig-osterhout. LMK if this is better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Very clear now
Description
Freshness for 'use desktop' section
Related issues or tickets
Reviews