Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGDOCS-2515a #22357

Merged
merged 7 commits into from
Apr 8, 2025
Merged

ENGDOCS-2515a #22357

merged 7 commits into from
Apr 8, 2025

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Apr 3, 2025

Description

Freshness for 'use desktop' section

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Apr 3, 2025
Copy link

netlify bot commented Apr 3, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6f8fd95
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67f3ef0ee4fa5000084a1132
😎 Deploy Preview https://deploy-preview-22357--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker requested a review from a team April 3, 2025 16:00
@aevesdocker aevesdocker marked this pull request as ready for review April 3, 2025 16:00

## Integrated terminal

From the Docker Dashboard footer, you can use the integrated terminal, on a running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like 2 different features got mixed in together. The terminal at the footer is different than the terminal in the container detail view in the Exec or Debug tab (or via the action menu).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have made clearer!

craig-osterhout
craig-osterhout previously approved these changes Apr 4, 2025
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Subjectively, I still think the features are mixed together, while having big differences that aren't clear.
They're both integrated terminals, but they have different entry points and different use-cases. The one at the footer opens in the host. The one in debug/exec/action menu opens in a container.

For example:

Using the integrated terminal is the same as running one of the following commands:

docker exec -it <container-id> /bin/sh
docker exec -it <container-id> cmd.exe when accessing Windows containers
docker debug <container-id> when using debug mode
The integrated terminal:

Persists your session if you navigate to another part of the Docker Desktop Dashboard and then return.
Supports copy, paste, search, and clearing your session.
Automatically detects the default user for a running container from the image's Dockerfile. If no user is specified, or you're using debug mode, it defaults to root.

None of that, except the persist and copy parts, applies to the terminal at the footer. Users can run docker exec in the footer terminal, but it's not the default entry point.

@aevesdocker
Copy link
Contributor Author

I see where I was going wrong @craig-osterhout. LMK if this is better

Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very clear now

@aevesdocker aevesdocker merged commit 49328ef into docker:main Apr 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants