Skip to content

ENGDOCS-2515b #22378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

ENGDOCS-2515b #22378

merged 3 commits into from
Apr 8, 2025

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Apr 7, 2025

Description

Freshness to uninstall, feedback, settings, back-up pages

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Apr 7, 2025
Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 06893d2
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67f52deacd8ac900084ebf5c
😎 Deploy Preview https://deploy-preview-22378--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker marked this pull request as ready for review April 7, 2025 14:42
@aevesdocker aevesdocker requested a review from a team April 7, 2025 15:23
container's configuration, for example labels and environment-variables, as a local image. Be aware that environment variables may contain sensitive
information such as passwords or proxy-authentication, so care should be taken
when pushing the resulting image to a registry.
Committing a container stores the container filesystem changes and some container configurations, such as labels and environment variables, as a local image. Be aware that environment variables may contain sensitive
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Committing a container stores the container filesystem changes and some container configurations, such as labels and environment variables, as a local image. Be aware that environment variables may contain sensitive
Committing a container stores filesystem changes and some container configurations, such as labels and environment variables, as a local image. Be aware that environment variables may contain sensitive

just a little nit for redundancy

Comment on lines 32 to 34
> [!TIP]
>
> [Set the repository visibility to private](](/manuals/docker-hub/repos/_index.md) if your image includes sensitive content.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> [!TIP]
>
> [Set the repository visibility to private](](/manuals/docker-hub/repos/_index.md) if your image includes sensitive content.
> [!TIP]
>
> [Set the repository visibility to private](/manuals/docker-hub/repos/_index.md) if your image includes sensitive content.

Comment on lines +44 to +56
1. Load your images.

If you backed up your images to a local tar file, use [`docker image load -i images.tar`](/reference/cli/docker/image/load.md)
to restore previously saved images.
- If you pushed to Docker Hub:

```console
$ docker pull <my-backup-image>
```

- If you saved a `.tar` file:

```console
$ docker image load -i images.tar
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing to change here, just such a good improvement! much more straightforward

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

By default, all notifications are turned on. You'll always receive error notifications and notifications about new Docker Desktop releases and updates.
By default, all general notifications are turned on. You'll always receive error notifications and notifications about new Docker Desktop releases and updates.

You can also [configure notification settings for Docker Scout-related issues](/manuals/scout/explore/dashboard.md#notification-settings).

Notifications momentarily appear in the lower-right of the Docker Desktop Dashboard and then move to the **Notifications** drawer. To open the **Notifications** drawer, select {{< inline-image src="../images/notifications.svg" alt="notifications" >}}.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in dark mode this icon is almost invisible. not sure if there is a grey image of this that would work for both light and dark modes. or if there are light and dark images

Copy link
Contributor Author

@aevesdocker aevesdocker Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have actually removed now. Everyone know what a notification icon is. the .svg was overkill


- **Enable privileged port mapping (Requires password)**. Starts the privileged helper process which binds the ports that are between 1 and 1024. For more information, see [permission requirements for macOS](/manuals/desktop/setup/install/mac-permission-requirements.md#binding-privileged-ports).
- **Allow privileged port mapping (Requires password)**. Starts the privileged helper process which binds the ports that are between 1 and 1024. For more information, see [permission requirements for macOS](/manuals/desktop/setup/install/mac-permission-requirements.md#binding-privileged-ports).

For more information on each configuration and use case, see [Permission requirements](/manuals/desktop/setup/install/mac-permission-requirements.md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this meant to be a part of the last bullet, or a line of it's own outside the list? it is hard to tell

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

Copy link
Collaborator

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments! love the freshness updates, the uninstall guide is awesome

Copy link
Collaborator

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@aevesdocker aevesdocker merged commit 902dcc0 into docker:main Apr 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants