Update dotnet-counters cli options to supply counter provider #35647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-counters released a breaking change in v9.0.621003. "Previously dotnet-counters allowed specifying a list of space separated counters prior to the -- token in collect/monitor mode. Counters must now be supplied explicitly in the --counters option as a list of comma-separated values." - https://github.com/dotnet/diagnostics/releases/tag/v9.0.621003
|
@dotnet-policy-service agree |
Updated the ms.date
Updated ms.date
wadepickett
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
@dylanrichards, thanks for catching this and the update!! Looks good to me, but I will give the author jamesnk a chance to look at it today in his own relative timezone before merging.
I also verified we didn't have any other instances of this problem in the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet-counters released a breaking change in v9.0.621003.
"Previously dotnet-counters allowed specifying a list of space separated counters prior to the -- token in collect/monitor mode. Counters must now be supplied explicitly in the --counters option as a list of comma-separated values." - https://github.com/dotnet/diagnostics/releases/tag/v9.0.621003
Fixes #35664
Internal previews