Skip to content

[UI] Allow to hide the Tour panel #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

[UI] Allow to hide the Tour panel #2816

merged 2 commits into from
Jun 26, 2025

Conversation

olgenn
Copy link
Collaborator

@olgenn olgenn commented Jun 17, 2025

@olgenn olgenn requested a review from peterschmidt85 June 17, 2025 20:41
@olgenn olgenn self-assigned this Jun 17, 2025
@peterschmidt85
Copy link
Contributor

All works fine except one use-case:

  • I log in as a user that already finished Tour steps.
  • The Tour sidebar is not shown
  • But if I click Tour, i see Show at startup is on

Screenshot 2025-06-18 at 20 32 14

  • Should it off

@olgenn
Copy link
Collaborator Author

olgenn commented Jun 19, 2025

@peterschmidt85 I think the toggle should be enabled by default, since it disables the Tour panel regardless of whether the user has completed the tour steps or not.

@peterschmidt85
Copy link
Contributor

I would auto-disable it.
Otherwise it’s misleading IMO. It says to show, but it doesn’t show.

@olgenn
Copy link
Collaborator Author

olgenn commented Jun 19, 2025

@peterschmidt85 if user already finished Tour steps and enabled this switcher, Tour panel will be opened after refresh page. Right?

@peterschmidt85
Copy link
Contributor

Yeah, let's try this behavior

@olgenn
Copy link
Collaborator Author

olgenn commented Jun 25, 2025

@peterschmidt85 I implemented this behavior. Please review it

@olgenn olgenn merged commit 0173a48 into master Jun 26, 2025
25 checks passed
@olgenn olgenn deleted the 286_hide_tour_panel branch June 26, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants