Use backticks around literals in documentation #14633
Merged
+34
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eksperimental
commented
Jul 8, 2025
| @@ -306,7 +306,7 @@ defmodule Regex do | |||
| * `:capture` - what to capture in the result. See the ["Captures" section](#module-captures) | |||
| to see the possible capture values. | |||
| * `:offset` - (since v1.12.0) specifies the starting offset to match in the given string. | |||
| Defaults to zero. | |||
| Defaults to `0`. | |||
There was a problem hiding this comment.
I took the liberty to replace the word with a literal here.
NickNeck
reviewed
Jul 9, 2025
Co-authored-by: Marcus Kruse <esurk.sucram@gmail.com>
josevalim
reviewed
Jul 9, 2025
This reverts commit be03324.
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally remove backticks around values which are not literals