Skip to content

Updated the header color and moved away from yellow shade to more dar… #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ganeshrvel
Copy link
Contributor

…ker one

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 10, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Theme update that establishes a more professional look by replacing the yellow/golden accent colors with a darker color scheme (#14151a) in the documentation header and navigation elements.

  • Changed header border color from golden (#bd8526) to dark gray (#14151a) in docs/_static/js/header_border.js
  • Added white background (#ffffff) for light mode in docs/extra/ragas-modern.css
  • Implemented consistent dark header/tab navigation background across themes
  • Removed yellow/orange divider elements from header for cleaner appearance

2 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile

@@ -1,6 +1,6 @@
const header_div = document.querySelector(".md-header");
const navbar_div = document.querySelector(".md-tabs");
const border_css = "2px solid #bd8526";
const border_css = "2px solid #14151a";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider using a CSS variable for the border color instead of hardcoding it. This would make theme changes easier to manage across the entire UI.

Comment on lines +23 to +26
/* Header background color for both light and dark modes */
.md-header {
background-color: #14151a !important;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Using !important here overrides Material Design's theme system. Consider using CSS custom properties or theme variables instead for better maintainability

Comment on lines +29 to +31
.md-tabs {
background-color: #14151a !important;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Duplicate !important usage. Consider consolidating header and tab styles into a single ruleset since they share the same color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant