Skip to content

Fix QF_SLIA parsing errors #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix QF_SLIA parsing errors #375

wants to merge 2 commits into from

Conversation

joaomhmpereira
Copy link
Member

Don't know if this way of propagating types is correct. It does get rid of parsing errors

@joaomhmpereira joaomhmpereira linked an issue Jun 21, 2025 that may be closed by this pull request
@joaomhmpereira
Copy link
Member Author

Had to do this for the re.inter operator:

| "re.inter", [ a; b ] -> Expr.raw_binop Ty_regexp Regexp_inter a b
| "re.inter", [ a; b; c ] ->
        Expr.raw_binop Ty_regexp Regexp_inter a
          (Expr.raw_binop Ty_regexp Regexp_inter b c)

Because, despite being considered a binary operator according to the SMT-LIB, some tests in the QF_SLIA benchmarks use it as a ternary operator.

@joaomhmpereira joaomhmpereira marked this pull request as ready for review June 23, 2025 14:54
@joaomhmpereira
Copy link
Member Author

Currently passing 99.74% of tests from the QF_SLIA benchmarks

@joaomhmpereira joaomhmpereira requested a review from filipeom June 23, 2025 14:55
@filipeom
Copy link
Member

I still haven't had time to check this. Hoping to get to it in the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve SMT-COMP's QF_SLIA parsing errors
2 participants