Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getsentry/sentry
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master@{1day}
Choose a base ref
...
head repository: getsentry/sentry
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 14 commits
  • 104 files changed
  • 11 contributors

Commits on May 19, 2025

  1. Copy the full SHA
    bdb70e6 View commit details
  2. fix(project-creation): Prefill form when project ID in URL matches lo…

    …calStorage data (#91517)
    
    - Fixes the issue where the form wasn’t pre-filled with data from a
    previously deleted project ( we want this when users go back in the
    flow)
    - Replaces the GettingStartedWithProject context with a simpler
    localStorage-based solution
    - Refactors the code to improve readability and clarity
    - Cleans up unused code and unnecessary logic
    - closes TET-369
    priscilawebdev authored May 19, 2025
    Copy the full SHA
    6f06e0f View commit details
  3. Copy the full SHA
    06389a1 View commit details
  4. fix(process-segments): Do not crash when messages are invalid (#91663)

    We don't get much from crashing while this entire deployment is still a
    noop.
    untitaker authored May 19, 2025
    Copy the full SHA
    b8796c4 View commit details
  5. ref(eslint): enable typescript-eslint/no-base-to-string (#91342)

    This PR enables the
    [no-base-to-string](https://typescript-eslint.io/rules/no-base-to-string/)
    typed eslint rule.
    
    This rule errors when we try to call `toString` or `toLocaleString` on
    something that potentially doesn’t produce useful information when
    stringified.
    
    It also catches string concatenations with `+` and interpolations in
    template literals `${expr}`.
    
    In our code-base, this often happens when we call `String(label)`, where
    label is typed as `React.ReactNode`. While a ReactNode _can_ be a
    string, if it’s a ReactElement like `<span>foo</span>`, the
    stringification would just yield `[object Object]`.
    
    The fix is to either narrow the type to e.g. `string | number`
    (depending on how its used) if we intend to only use it with values that
    are stringifiable or to avoid making a string out of it. Sometimes, I
    had to `eslint-disable` because we’d need a larger refactor.
    TkDodo authored May 19, 2025
    Copy the full SHA
    1b4ce1b View commit details
  6. storybook: add markdown support (#91817)

    Add mdx support for stories. This allows us to write mdx compliant
    markup which is commonly supported by documentation framework and
    friendlier to write than jsx.
    
    The mdx loader also conveniently exports a default export which means
    that we can omit the concept of storybook entirely
    JonasBa authored May 19, 2025
    Copy the full SHA
    20b05fc View commit details
  7. chore(issues): Remove unused llmMonitoringSection (#91816)

    Cleanup after removing from the issue details page in #91776.
    mrduncan authored May 19, 2025
    Copy the full SHA
    c5029f6 View commit details
  8. Copy the full SHA
    f431944 View commit details
  9. ref(js): No need to pass timezone to moment (#91862)

    We already set the default timezone in moment.tz to the user's
    configured timezone.
    
    This is done here
    https://github.com/getsentry/sentry/blob/20b05fc91a4ad6783bff1875327f4570bcfb5d00/static/app/stores/configStore.tsx#L47
    
    We had two types of moment invocations that did not require us to pass
    the users timezone:
    
    - `moment.tz(myDate, userTimezone)`
    - `moment(myDate).tz(userTimezone)`
    
    Here are some examples showing that these work fine WITHOUT providing
    the timezone and letting moment fall back to it's default
    
    ```tsx
    // Set timezone to America/New_York. We ALWAYS were doing this
    const userTz = 'America/New_York';
    moment.tz.setDefault(userTz);
    
    // A few Example timestamps. All of our server response timestamps will
    // be at UTC, but for illustration purposes we can also look at dates
    // specified in other timezones
    const dateUTC = '2014-06-01T12:00:00-00:00';
    const dateNY = '2014-06-01T12:00:00-04:00';
    
    // Calling moment.tz with or without the timezone always localizes to
    // America/New_York because of the default
    moment.tz(dateUTC, userTz).format(); // '2014-06-01T08:00:00-04:00'
    moment(dateUTC).tz(userTz).format(); // '2014-06-01T08:00:00-04:00'
    moment(dateUTC).format();            // '2014-06-01T08:00:00-04:00'
    
    // Passing a date as a different timezone
    moment.tz(dateLA, userTz).format();  // '2014-06-01T15:00:00-04:00'
    moment(dateLA).format();             // '2014-06-01T15:00:00-04:00'
    ```
    evanpurkhiser authored May 19, 2025
    Copy the full SHA
    20a952d View commit details
  10. feat(autofix): New onboarding/notice flow (#91855)

    Instead of a bunch of banners at the top, creates a nice set of guided
    steps. Also adds steps for enabling automation in settings and for
    creating the recommended fixability-score-based view. (title says "Debug
    Faster with Seer," some screenshots are outdated)
    
    
    
    <img width="796" alt="Screenshot 2025-05-17 at 9 36 47 AM"
    src="https://github.com/user-attachments/assets/07baf09b-51cd-44cf-91e9-ee1d73161385"
    />
    <img width="790" alt="Screenshot 2025-05-17 at 9 36 49 AM"
    src="https://github.com/user-attachments/assets/c2d7fa6f-acdc-4b3d-b5c4-1088474b8c83"
    />
    <img width="768" alt="Screenshot 2025-05-17 at 9 36 53 AM"
    src="https://github.com/user-attachments/assets/59df2406-6fa0-4175-af02-a1d31dc9c8f2"
    />
    <img width="784" alt="Screenshot 2025-05-17 at 11 24 17 AM"
    src="https://github.com/user-attachments/assets/0939a0ed-bddd-4172-a515-b9202d311c53"
    />
    
    
    Also in repo settings, add a link to manage organization repos if there
    are no repos to add.
    
    <img width="292" alt="Screenshot 2025-05-17 at 9 52 38 AM"
    src="https://github.com/user-attachments/assets/751cfa52-8f96-4076-8ba9-e8bb2f73e98c"
    />
    roaga authored May 19, 2025
    Copy the full SHA
    c4a1027 View commit details
  11. chore(seer): Consolidate automation feature flags (#91856)

    Switching everything from `projects:trigger-issue-summary-on-alerts` to
    `organizations:trigger-autofix-on-issue-summary` so that we only have
    one feature flag controlling all automation features. (names are
    meaningless now but we can handle that later)
    
    Will remove the unused flag in a follow up
    roaga authored May 19, 2025
    Copy the full SHA
    91db659 View commit details
  12. chore(ui): Use rspack in dev-ui by default (#91866)

    Adds a `dev-ui-webpack` and makes rspack the default dev-ui
    scttcper authored May 19, 2025
    Copy the full SHA
    8e1cbf2 View commit details
  13. ref: remove extraneous unique constraint on groupedmessage (#91861)

    this is not present in production and afaict would be redundant with the
    PKEY constraint
    
    <!-- Describe your PR here. -->
    asottile-sentry authored May 19, 2025
    Copy the full SHA
    864225f View commit details
  14. ref: remove db_index=True on non-indexed columns (#91863)

    these were added with sql without index so the indexes do not exist
    
    <!-- Describe your PR here. -->
    asottile-sentry authored May 19, 2025
    Copy the full SHA
    b1d0b74 View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff master@{1day}...master