Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: github/details-menu-element
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: github/details-menu-element
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: focus-active-descendant
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 4 files changed
  • 2 contributors

Commits on Nov 9, 2019

  1. Focus menu items with aria-activedescendant

    Leave DOM focus on the summary that opened the menu or a filter input
    inside the menu. Navigating items with arrow keys should not move focus
    away from the input field.
    dgraham committed Nov 9, 2019
    Copy the full SHA
    0afc523 View commit details

Commits on Nov 12, 2019

  1. Reveal menu item when focused

    dgraham committed Nov 12, 2019
    Copy the full SHA
    5e112af View commit details
  2. Copy the full SHA
    aa214f7 View commit details
  3. Manage active descendant on menu role

    A menu with a filtering input at the top cannot itself be role=menu
    because it hides the input from screen readers. The following
    relationship is required.
    
        <details-menu role="none">
          <input>
          <div role="menu" aria-activedescendant="i1">
            <button id="i1" role="menuitem></button>
          </div>
        </details-menu>
    
    Managing focus with aria-activedescendant requires the attribute to be
    attached to the role=menu element in order for the focused item to be
    announced.
    dgraham committed Nov 12, 2019
    Copy the full SHA
    134317e View commit details
  4. Copy the full SHA
    0dcce65 View commit details

Commits on Dec 2, 2019

  1. Use summary as active descendant control

    NVDA requires the element with DOM focus to manage the active
    descendant. We use summary or an optional input field as the focused
    element.
    
    Co-authored-by: Mu-An Chiou <me@muanchiou.com>
    dgraham and muan committed Dec 2, 2019
    Copy the full SHA
    a026af1 View commit details
  2. Copy the full SHA
    1c07f40 View commit details
  3. Copy the full SHA
    73588b5 View commit details
  4. Use capture property

    Co-authored-by: Mu-An Chiou <me@muanchiou.com>
    dgraham and muan committed Dec 2, 2019
    Copy the full SHA
    ca1124e View commit details
  5. Describe each demo

    muan authored and dgraham committed Dec 2, 2019
    Copy the full SHA
    2abaf73 View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff main...focus-active-descendant