Skip to content

Broken in-page links due to incorrect heading IDs #36832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
shusch opened this issue Mar 14, 2025 · 4 comments
Open
1 task done

Broken in-page links due to incorrect heading IDs #36832

shusch opened this issue Mar 14, 2025 · 4 comments
Labels
content This issue or pull request belongs to the Docs Content team localization Issue or PR relating to translation or localization

Comments

@shusch
Copy link

shusch commented Mar 14, 2025

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/fr/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address

Although the example is in French, this problem occurs across all non-English languages.

What part(s) of the article would you like to see updated?

The following in-page links do not work in languages other than English.
https://github.com/github/docs/blob/main/content/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address.md?plain=1#L36

https://github.com/github/docs/blob/main/data/reusables/user-settings/no-verification-disposable-emails.md

This issue occurs because translated headings are directly used as their element IDs, causing inconsistencies with the links.
It seems that this only affects headings that include Liquid statements.

If the heading element IDs remain unchanged during translation, the links should work correctly.

Additional information

No response

@shusch shusch added the content This issue or pull request belongs to the Docs Content team label Mar 14, 2025
Copy link

welcome bot commented Mar 14, 2025

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 14, 2025
@janiceilene
Copy link
Contributor

Thanks so much for opening an issue and letting us know @shusch! I'll get this triaged to our localization folks and see what we can do.

@janiceilene janiceilene added localization Issue or PR relating to translation or localization and removed triage Do not begin working on this issue until triaged by the team labels Mar 14, 2025
@csigs
Copy link

csigs commented Mar 15, 2025

Thank you for your feedback. We will review the issue (ICX ADO Tracking Reference: 1039281).

@github github deleted a comment from Tehrani77 Mar 17, 2025
@csigs
Copy link

csigs commented Apr 13, 2025

Thank you for your feedback. We will review the issue (ICX ADO Tracking Reference: 1046038).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team localization Issue or PR relating to translation or localization
Projects
None yet
Development

No branches or pull requests

4 participants
@janiceilene @csigs @shusch and others