Skip to content

Failing integration tests when running locally #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aeisenberg opened this issue Oct 18, 2021 · 1 comment
Open

Failing integration tests when running locally #972

aeisenberg opened this issue Oct 18, 2021 · 1 comment
Labels
bug Something isn't working VSCode

Comments

@aeisenberg
Copy link
Contributor

When running integration tests locally, they pass the first time you run them and fail subsequently.

In particular, extensions/ql-vscode/src/vscode-tests/cli-integration/databases.test.ts should add a database from a folder fails. And I can get it passing if I clear out all of the vscode temporary databases in /private/var/folders/41/kxmfbgxj40dd2l_x63x9fw7c0000gn/T/tmp-*. (This is likely a different folder on different machines.)

The integration tests are passing on CI because they always run in a clean state.

I can think of two possibilities that might fix the problem:

  1. Run cleanup code (eg- delete all databases) after running all the tests
  2. Ensure we have a clean slate before starting any tests.

version: CodeQL extension version: 1.5.6 CodeQL CLI version: 2.6.3 Platform: darwin x64

@aeisenberg aeisenberg added the bug Something isn't working label Oct 18, 2021
@aeisenberg
Copy link
Contributor Author

Now, after cleaning out my temporary directory, I can't reproduce. This may be a temporary issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VSCode
Projects
None yet
Development

No branches or pull requests

1 participant