SIGINT-3174: Jenkins [dev] : Support self signed certs #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for self-signed certificates by introducing two new parameters (network_ssl_cert_file and network_ssl_trustAll) and updates several classes and tests to pass an additional scanParameters map.
- Integrates self-signed cert support into HTTP connections via Utility.getHttpURLConnection
- Updates test cases and configuration UIs to handle the new network SSL parameters
- Refactors interfaces and parameter mapping for improved network configuration support
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| BridgeDownloadParameterServiceTest.java | Updated constructor calls with scanParameters |
| ToolsParameterServiceTest.java | Renamed and enhanced test for network input JSON with new SSL parameters |
| ParameterMappingServiceTest.java | Adjusted assertions to reflect the additional network SSL parameters |
| Utility.java | Updated getHttpURLConnection to support self-signed certs via SSL context setup |
| config.jelly & CSS files | Updated UI elements and styling for network configuration support |
| Various Java source files (BridgeInstall, BridgeDownload, etc.) | Updated constructors and method calls to propagate scanParameters |
src/main/java/io/jenkins/plugins/security/scan/global/Utility.java
Outdated
Show resolved
Hide resolved
src/main/java/io/jenkins/plugins/security/scan/service/ToolsParameterService.java
Show resolved
Hide resolved
zaman-akib
requested changes
Jun 19, 2025
src/main/java/io/jenkins/plugins/security/scan/global/Utility.java
Outdated
Show resolved
Hide resolved
| return null; | ||
| } | ||
|
|
||
| public static HttpURLConnection createTrustAllConnection(URL url, EnvVars envVars, LoggerWrapper logger) |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Generally unsafe method calls Warning
|
|
||
| public static HttpURLConnection createCertFileConnection( |
Check warning
Code scanning / Jenkins Security Scan
Jenkins: Generally unsafe method calls Warning
zaman-akib
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network_ssl_cert_fileandnetwork_ssl_trustAlland reconfigured thegetHttpURLConnectionmethod to support the self signed certificates.SecurityScanandPrCommentScaninterfaces.