Skip to content

feat: add command to show version #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025
Merged

feat: add command to show version #604

merged 2 commits into from
Jul 11, 2025

Conversation

ym
Copy link
Contributor

@ym ym commented Jun 12, 2025

No description provided.

Copy link
Contributor

@IDisposable IDisposable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :)

@SuperQ
Copy link
Contributor

SuperQ commented Jun 12, 2025

The github.com/prometheus/common/version package also includes a nice version output.

https://github.com/prometheus/common/blob/main/version/info.go#L40-L48

That's part of why I put the package in main.go, so it could be used later. :)

@ym
Copy link
Contributor Author

ym commented Jun 19, 2025

The github.com/prometheus/common/version package also includes a nice version output.

https://github.com/prometheus/common/blob/main/version/info.go#L40-L48

That's part of why I put the package in main.go, so it could be used later. :)

Yea, I wanted to use this function, but it doesn't allow overriding versionInfoTmpl. I ended up creating something similar, though.

@ym ym force-pushed the feat/cli-version branch from 9bde820 to 05eb572 Compare July 11, 2025 09:27
@ym ym force-pushed the feat/cli-version branch from 05eb572 to fe52567 Compare July 11, 2025 09:30
@ym ym merged commit d704fcc into jetkvm:dev Jul 11, 2025
2 checks passed
adammkelly pushed a commit to adammkelly/kvm that referenced this pull request Jul 15, 2025
* feat: add -version flag for jetkvm_app

* move code to kvm package
adammkelly pushed a commit to adammkelly/kvm that referenced this pull request Jul 15, 2025
* feat: add -version flag for jetkvm_app

* move code to kvm package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants