test(e2e): add e2e tests for authz, secret, log, accesslog, version and dump #1316

ravjot07 · 2025-04-18T21:12:02Z

test(e2e): add end-to-end tests for kmeshctl commands

authz: enable/disable/status subcommands
secret: create and update IPsec secret
log: list, get and set logger levels
accesslog: enable/disable per-pod and cluster
dump: kernel-native, dual-engine, and invalid-mode handling
version: version for kmeshctl, for specific pod

Each test locates a running kmesh daemon pod, waits for readiness, invokes the CLI, and asserts expected behaviour or output.

Signed-off-by: ravjot07 <ravu2004@gmail.com>

kmesh-bot · 2025-04-18T21:12:07Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lec-bit for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov · 2025-04-18T21:29:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.26%. Comparing base (44253ce) to head (4cd923f).
Report is 16 commits behind head on main.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2122a...4cd923f. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

yp969803 · 2025-04-20T01:20:28Z

accesslogs are reported periodically after (5 sec) for long tcp_connections, can you add a e2e test for this ?? @ravjot07

ravjot07 · 2025-04-20T18:54:40Z

accesslogs are reported periodically after (5 sec) for long tcp_connections, can you add a e2e test for this ?? @ravjot07

ya sure

YaoZengzeng · 2025-04-21T01:34:13Z

test/e2e/kmeshctl_test.go

+	"bufio"
+	"context"
+	"crypto/rand"
+    "encoding/hex"


Please use gofmt to format the code

YaoZengzeng · 2025-04-21T01:43:51Z

test/e2e/kmeshctl_test.go

+	}
+ }
+
+ func runAuthzCmd(args ...string) (string, error) {


We can merge runAuthCmd, runVersionCmd, etc and pass parameters as needed, because you have not structed any subcommands yet.

Please fix this

done pl. review

YaoZengzeng · 2025-04-21T01:45:58Z

test/e2e/kmeshctl_test.go

+
+	t.Run("kernel-native", func(t *testing.T) {
+		out, err := runDumpCmd(pod, "kernel-native")
+		t.Logf("Output of 'kmeshctl dump %s kernel-native':\n%s", pod, out)


You should at least check if the command output contains certain key strings instead of printing the log directly.

done i have updated the test

YaoZengzeng · 2025-04-24T02:02:28Z

ping @ravjot07

Signed-off-by: ravjot07 <ravu2004@gmail.com>

YaoZengzeng · 2025-04-27T06:11:54Z

test/e2e/kmeshctl_test.go

+
+func TestKmeshctlVersion(t *testing.T) {
+	pod := findKmeshPod(t)
+	waitForPodRunning(t, pod)


We can ensure that the Kmesh pods are in the running status before running this test, ref: https://github.com/kmesh-net/kmesh/blob/main/test/e2e/run_test.sh#L118

done pl. review

Signed-off-by: ravjot07 <ravu2004@gmail.com>

kmesh-bot · 2025-05-04T05:01:10Z

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

YaoZengzeng · 2025-05-06T07:32:04Z

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

@ravjot07 you should use git rebase instead of merging.

YaoZengzeng · 2025-05-06T07:47:17Z

test/e2e/kmeshctl_test.go

+	return outStr, err
+}
+
+func waitForPodReady(t *testing.T, pod string) {


remove this function

YaoZengzeng · 2025-05-06T07:48:51Z

test/e2e/kmeshctl_test.go

+	}
+}
+
+func findKmeshPod(t *testing.T) string {


It looks like it is implemented in init and can be deleted?

YaoZengzeng · 2025-05-06T07:57:39Z

test/e2e/kmeshctl_test.go

+	})
+
+	t.Run("list", func(t *testing.T) {
+		time.Sleep(2 * time.Second)


It is better not to sleep directly, polling is better, and an error will be reported if the timeout occurs.

i have changes this part using polling

YaoZengzeng · 2025-05-06T07:58:05Z

test/e2e/run_test.sh

@@ -272,8 +290,11 @@ if [[ -z "${SKIP_SETUP:-}" ]]; then
 fi

 if [[ -z "${SKIP_BUILD:-}" ]]; then
-    setup_kind_registry
-    build_and_push_images
+     setup_kind_registry


indentation

YaoZengzeng · 2025-05-06T07:59:59Z

test/e2e/run_test.sh

+     setup_kind_registry
+   build_and_push_images
+   echo "Building kmeshctl CLI..."
+   make kmeshctl || { echo "Failed to build kmeshctl" >&2; exit 1; }


I thought we don't compile kmeshctl? Already done in previous build_and_push_images?

Signed-off-by: ravjot07 <ravu2004@gmail.com>

YaoZengzeng · 2025-05-13T06:24:44Z

test/e2e/run_test.sh

@@ -209,6 +209,24 @@ function cleanup_docker_registry() {
 	docker rm "${KIND_REGISTRY_NAME}" || echo "Failed to remove or no such registry '${KIND_REGISTRY_NAME}'."
 }

+TMPBIN="${TMPBIN:-$(mktemp -d)/bin}"
+mkdir -p "$TMPBIN"
+export PATH="$PATH:$TMPBIN"


we already have this dicretory

YaoZengzeng · 2025-05-13T06:25:04Z

test/e2e/run_test.sh

+# Function to install kmeshctl into the test environment.
+function install_kmeshctl() {
+   echo "Installing kmeshctl CLI into test environment..."
+   if [[ -f "$ROOT_DIR/kmeshctl" ]]; then


no need to check, just copy it.

YaoZengzeng · 2025-05-13T06:26:13Z

test/e2e/kmeshctl_test.go

+// Package‐level init ensures Kmesh is ready before any tests run.
+func init() {
+	// 1) Wait up to 2 minutes for all Kmesh pods to become Ready.
+	wait := exec.Command("kubectl", "-n", kmeshNamespace, "wait",


I have already said that the Kmesh pod is ready, no need to check it again

ravjot07 added 6 commits April 18, 2025 23:47

updated run_test.sh to install kmeshctl in e2e

20078c4

Signed-off-by: ravjot07 <ravu2004@gmail.com>

test: added test for kmeshctl version

8ca5412

Signed-off-by: ravjot07 <ravu2004@gmail.com>

test: added test for kmeshctl Dump and accesslog

d30a318

Signed-off-by: ravjot07 <ravu2004@gmail.com>

test: added test for kmeshctl log and secret

1eda40b

Signed-off-by: ravjot07 <ravu2004@gmail.com>

minor changes

f783cd2

Signed-off-by: ravjot07 <ravu2004@gmail.com>

test: added test for kmeshctl authz

02633f8

Signed-off-by: ravjot07 <ravu2004@gmail.com>

kmesh-bot requested review from lec-bit and YaoZengzeng April 18, 2025 21:12

kmesh-bot added the size/L label Apr 18, 2025

YaoZengzeng reviewed Apr 21, 2025

View reviewed changes

ravjot07 force-pushed the ctl_e2e_test branch from f604b27 to 02633f8 Compare April 25, 2025 09:38

kmesh-bot added the do-not-merge/contains-merge-commits label Apr 25, 2025

ravjot07 force-pushed the ctl_e2e_test branch from 8a79186 to 5b61e92 Compare April 25, 2025 19:34

kmesh-bot removed the do-not-merge/contains-merge-commits label Apr 25, 2025

Updated dump test

43d7bb7

Signed-off-by: ravjot07 <ravu2004@gmail.com>

ravjot07 force-pushed the ctl_e2e_test branch from 5b61e92 to 43d7bb7 Compare April 25, 2025 19:49

minor changes

2af2fee

Signed-off-by: ravjot07 <ravu2004@gmail.com>

YaoZengzeng reviewed Apr 27, 2025

View reviewed changes

ravjot07 and others added 2 commits May 4, 2025 10:05

add: waypoints test and minor chages in structure of rest of the code

f5bf4de

Signed-off-by: ravjot07 <ravu2004@gmail.com>

Merge branch 'main' into ctl_e2e_test

4cd923f

kmesh-bot added the do-not-merge/contains-merge-commits label May 4, 2025

YaoZengzeng reviewed May 6, 2025

View reviewed changes

ravjot07 and others added 2 commits May 13, 2025 10:56

minor changes

37b1392

Signed-off-by: ravjot07 <ravu2004@gmail.com>

Merge branch 'main' into ctl_e2e_test

c5d65dd

YaoZengzeng reviewed May 13, 2025

View reviewed changes

test(e2e): add e2e tests for authz, secret, log, accesslog, version and dump #1316

Are you sure you want to change the base?

test(e2e): add e2e tests for authz, secret, log, accesslog, version and dump #1316

Conversation

ravjot07 commented Apr 18, 2025

Uh oh!

kmesh-bot commented Apr 18, 2025

Uh oh!

codecov bot commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yp969803 commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ravjot07 commented Apr 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YaoZengzeng commented Apr 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kmesh-bot commented May 4, 2025

Uh oh!

YaoZengzeng commented May 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Apr 18, 2025 •

edited

Loading

yp969803 commented Apr 20, 2025 •

edited

Loading