output kmesh log when e2e test failed #1393
Conversation
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
YaoZengzeng
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
YaoZengzeng
force-pushed
the
cross
branch
6 times, most recently
from
6d794b7 to
2432a38
Compare
YaoZengzeng
force-pushed
the
cross
branch
8 times, most recently
from
a8407e9 to
a4ddeb6
Compare
YaoZengzeng
force-pushed
the
cross
branch
5 times, most recently
from
5f01311 to
3a0bcec
Compare
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
YaoZengzeng
changed the title
|
@hzxuzhonghu ptal |
| @@ -11,6 +11,8 @@ DEFAULT_KIND_IMAGE="kindest/node:v1.30.0@sha256:047357ac0cfea04663786a612ba1eaba | |||
|
|
|||
| ISTIO_VERSION=${ISTIO_VERSION:-"1.22.0"} | |||
|
|
|||
| LOGFILE="kmesh_daemon.log" | |||
There was a problem hiding this comment.
We cannot see it once CI job running failed
test/e2e/run_test.sh
Outdated
| bash -c "$cmd" || { | ||
| cat $LOGFILE | ||
| rm $LOGFILE | ||
| exit 1 |
There was a problem hiding this comment.
why exit without cleaning up. I think failure does not mean not cleaning up, they are orthogonal
There was a problem hiding this comment.
Good catch, we should rm the file anyway
|
@hzxuzhonghu updated |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1390
Special notes for your reviewer:
Does this PR introduce a user-facing change?: