-
Notifications
You must be signed in to change notification settings - Fork 108
Fix authz during shutdown #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refines the handling of unhealthy workloads by ensuring that such workloads are removed from the BPF endpoint map while remaining in the frontend/backend maps for authorization purposes. The changes include updating test assertions for workload status, refactoring the processor to call a new handler for unhealthy workloads, and adjusting logging levels and inline comments in BPF C code.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
pkg/controller/workload/workload_processor_test.go | Updated tests to verify unhealthy workloads are removed from the endpoint map while retained in frontend/backend maps. |
pkg/controller/workload/workload_processor.go | Introduced handleUnhealthyWorkload to manage unhealthy workloads and updated comments accordingly. |
bpf/kmesh/workload/xdp.c | Changed log level from INFO to DEBUG in the xdp routine. |
bpf/kmesh/workload/include/frontend.h | Updated inline comments to clarify that unhealthy backend status is not checked. |
@@ -34,7 +34,7 @@ static inline int frontend_manager(struct kmesh_context *kmesh_ctx, frontend_val | |||
direct_backend = true; | |||
} | |||
|
|||
if (direct_backend) { | |||
if (direct_backend) { // in this case, we donot check the healthy status of the backend, just let it go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider correcting 'donot' to 'do not' for improved clarity.
if (direct_backend) { // in this case, we donot check the healthy status of the backend, just let it go | |
if (direct_backend) { // in this case, we do not check the healthy status of the backend, just let it go |
Copilot uses AI. Check for mistakes.
…rontend map for xdp use Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
e9d3927
to
897be44
Compare
Codecov ReportAttention: Patch coverage is
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created: #1400 |
…rontend map for xdp use
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1381
Special notes for your reviewer:
Does this PR introduce a user-facing change?: