correct guidance for building e2e.test with debug symbols #8397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
BenTheElder
commented
Mar 25, 2025
| make WHAT=test/e2e/e2e.test GOGCFLAGS="all=-N -l" GOLDFLAGS="" | ||
| # DBG=1 enables necessary debug options and disables stripping binaries | ||
| # see the makefile upstream, or use UBE_VERBOSE=3 to get the actual build commands | ||
| make WHAT=test/e2e/e2e.test DBG=1 | ||
| ``` | ||
|
|
||
| Then set the env var `E2E_TEST_DEBUG_TOOL=delve` and then run the test with `./hack/ginkgo.sh` instead of `kubetest`, you should see the delve command line prompt |
There was a problem hiding this comment.
Suggested change
| Then set the env var `E2E_TEST_DEBUG_TOOL=delve` and then run the test with `./hack/ginkgo.sh` instead of `kubetest`, you should see the delve command line prompt | |
| Then set the env var `E2E_TEST_DEBUG_TOOL=dlv` and then run the test with `./hack/ginkgo-e2e.sh` instead of `kubetest`, you should see the delve command line prompt |
- dlv not delve AFAICT (the CLI != the project name)
- ginkgo-e2e.sh, not ginkgo.sh
That's also not enough to get it to actually work though, E2E_TEST_DEBUG_TOOL=dlv KUBERNETES_PROVIDER=skeleton ./hack/ginkgo-e2e.sh --ginkgo.focus="HTTP.proxy" fails with no output.
KUBERNETES_PROVIDER=skeleton ./hack/ginkgo-e2e.sh --ginkgo.focus="HTTP.proxy" works.
There was a problem hiding this comment.
I didn't fully get this sorted out, patrick indicated that he's not actually using this mode and is running the binaries directly ...
There was a problem hiding this comment.
Gotcha, we can followup on it.
soltysh
reviewed
Apr 16, 2025
| make WHAT=test/e2e/e2e.test GOGCFLAGS="all=-N -l" GOLDFLAGS="" | ||
| # DBG=1 enables necessary debug options and disables stripping binaries | ||
| # see the makefile upstream, or use UBE_VERBOSE=3 to get the actual build commands | ||
| make WHAT=test/e2e/e2e.test DBG=1 | ||
| ``` | ||
|
|
||
| Then set the env var `E2E_TEST_DEBUG_TOOL=delve` and then run the test with `./hack/ginkgo.sh` instead of `kubetest`, you should see the delve command line prompt |
Co-authored-by: Maciej Szulik <soltysh@gmail.com>
soltysh
approved these changes
Apr 16, 2025
k8s-ci-robot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes # N/A
DBG=1 enables these settings and also disables stripping the binaries. The current instructions do not produce a debuggable binary.
NOTE: this change does produce a binary that can be debugged, the next bit about using it with "ginkgo.sh" is also wrong but I'm not done iterating on that part. I filed this to avoid forgetting fixing the part which I know the correct fix for already.
/cc @pohly @aojea