WIP breaking(sqlite): libsqlite3-sys versioning, feature flags, extension loading is unsafe
#3928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
changed the title
libsqlite3-sys versioning, feature flags, ext…libsqlite3-sys versioning, feature flags, extension loading is unsafe
…ension loading `unsafe`
# Changes to unreleased code (fold together with related PRs)
* Rename config key `common.drivers.sqlite.load-extensions` to `drivers.sqlite.unsafe-load-extensions`
* Added `drivers.mysql`, `drivers.postgres`, and support for future external drivers
# Breaking Changes
* Changed `libsqlite3-sys` versioning policy to use version ranges
* Diesel has been using this successfully for many years: https://github.com/diesel-rs/diesel/blob/cdf7c51c35da7ebc6fb12e71857bfba8487c20cd/diesel/Cargo.toml#L53
* Mark `SqliteConnectOptions::extension()` and `::extension_with_entrypoint()` as `unsafe`
* Added new non-default features corresponding to conditionally compiled SQLite APIs:
* `sqlite-deserialize` enabling `SqliteConnection::serialize()` and `SqliteConnection::deserialize()`
* `sqlite-load-extension` enabling `SqliteConnectOptions::extension()` and `::extension_with_entrypoint()`
* `sqlite-unlock-notify` enables internal use of `sqlite3_unlock_notify()`
# TODO
- [ ] `sqlite3_value` is not safe to access concurrently
- [ ] list all the issues this fixes
abonander
force-pushed
the
ab/sqlite-range
branch
from
f9fa141 to
17e7428
Compare
This was referenced Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to unreleased code (fold together with related PRs)
common.drivers.sqlite.load-extensionstodrivers.sqlite.unsafe-load-extensionsdrivers.mysql,drivers.postgres, and support for future external driversBreaking Changes
libsqlite3-sysversioning policy to use version rangesSqliteConnectOptions::extension()and::extension_with_entrypoint()asunsafesqlite-deserializeenablingSqliteConnection::serialize()andSqliteConnection::deserialize()sqlite-load-extensionenablingSqliteConnectOptions::extension()and::extension_with_entrypoint()sqlite-unlock-notifyenables internal use ofsqlite3_unlock_notify()TODO
sqlite3_valueis not safe to access concurrently