fix: Some languages not detected when importing from SnippetsLab #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While taking massCode for a test drive, I noticed all my shell script snippets that were imported from a SnippetsLab JSON file had been marked as plain text. The problem is that "Bash" (via "BashLexer") does not match the "sh" that massCode expects. This is a quick PR to manually handle that case. Note: A good future task might be to check if there are other languages with this same problem by checking each of [Pygments supported languages' Lexer class names](https://pygments.org/languages/) (which is what SnippetsLab is using under-the-hood) against the [list massCode's language IDs](https://github.com/massCodeIO/massCode/blob/834eb28693b8262982a3ea1fc57f5ba948bd8411/src/shared/types/renderer/editor/index.d.ts).
brandt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While taking massCode for a test drive, I noticed all my shell script snippets that were imported from a SnippetsLab JSON file had been marked as plain text.
The problem is that "Bash" (via "BashLexer") does not match the "sh" that massCode expects. Similarly, massCode expects "golang" instead of "Go".
This is a quick PR to fix a few of those cases.
Note: A good future task might be to check if there are other languages with this same problem by checking each of Pygments supported languages' Lexer class names (which is what SnippetsLab is using under-the-hood) against the list massCode's language IDs.
What kind of change does this PR introduce?
Validations