chore: Fix memory leak in callbackRetText function

hionay · hionay · commit d9168d5b4471 · 2024-07-12T17:14:15.000+03:00
diff --git a/callback.go b/callback.go
@@ -345,7 +345,9 @@ func callbackRetText(ctx *C.sqlite3_context, v reflect.Value) error {
 	if v.Type().Kind() != reflect.String {
 		return fmt.Errorf("cannot convert %s to TEXT", v.Type())
 	}
-	C._sqlite3_result_text(ctx, C.CString(v.Interface().(string)))
+	cstr := C.CString(v.Interface().(string))
+	defer C.free(unsafe.Pointer(cstr))
+	C._sqlite3_result_text(ctx, cstr)
 	return nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,9 @@ func callbackRetText(ctx *C.sqlite3_context, v reflect.Value) error {`
`345`	`345`	`if v.Type().Kind() != reflect.String {`
`346`	`346`	`return fmt.Errorf("cannot convert %s to TEXT", v.Type())`
`347`	`347`	`}`
`348`		`- C._sqlite3_result_text(ctx, C.CString(v.Interface().(string)))`
	`348`	`+ cstr := C.CString(v.Interface().(string))`
	`349`	`+ defer C.free(unsafe.Pointer(cstr))`
	`350`	`+ C._sqlite3_result_text(ctx, cstr)`
`349`	`351`	`return nil`
`350`	`352`	`}`
`351`	`353`