Skip to content

stl/CMakeLists.txt: Remove redundant Synchronization.lib #5496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented May 12, 2025

Followup to #5432, which linked against Synchronization.lib for all architectures.

This will be paired with a change to MSVC-internal src/vctools/crt/crt_build.targets (validated internally).

Followup to GH 5432, which linked against `Synchronization.lib` for all architectures.

This will be paired with a change to MSVC-internal `src/vctools/crt/crt_build.targets`.
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner May 12, 2025 00:03
@StephanTLavavej StephanTLavavej added the build Related to the build system label May 12, 2025
@StephanTLavavej StephanTLavavej added the ARM64 Related to the ARM64 architecture label May 12, 2025
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews May 12, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Final Review in STL Code Reviews May 12, 2025
@StephanTLavavej StephanTLavavej moved this from Final Review to Ready To Merge in STL Code Reviews May 15, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews May 16, 2025
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit e2f43c5 into microsoft:main May 17, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews May 17, 2025
@StephanTLavavej StephanTLavavej deleted the synchronization branch May 17, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM64 Related to the ARM64 architecture build Related to the build system
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants