<filesystem>: Fix the path returned when there is an error with temp_directory_path
#5570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGuteniev
reviewed
Jun 3, 2025
| @@ -4039,9 +4039,8 @@ namespace filesystem { | |||
| _STD filesystem::permissions(_Target, _Perms, perm_options::replace, _Ec); | |||
| } | |||
|
|
|||
| _EXPORT_STD _NODISCARD inline path temp_directory_path(error_code& _Ec) { | |||
| _NODISCARD inline path _Temp_directory_path_impl(error_code& _Ec) { | |||
There was a problem hiding this comment.
What are advantages of wrapping the existent function instead of clearing that string on error right here?
There was a problem hiding this comment.
When an error occurs, _impl does not clear the path, but the error_code version does. Therefore, the exception version needs to use _impl to reuse code instead of the error_code version in order to report the path.
There was a problem hiding this comment.
Oh, I see the path is the part of the exception. Then it makes sense!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5557.