Skip to content

Added Czech localization #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

ioma8
Copy link

@ioma8 ioma8 commented Jun 3, 2025

I have added support for czech language as well as correct translations for all keys in src/bin/edit/localization.rs . I am czech native and did the translations according to how standartly such applications are translated in my language. I also double checked the translations in the running program UI as well.

@ioma8
Copy link
Author

ioma8 commented Jun 3, 2025

@microsoft-github-policy-service agree

@jakubtalich
Copy link

jakubtalich commented Jun 3, 2025

I approve of this translation with this additional change:
"Match Case" --> "Velká/malá písmena" (to make it shorter for the TUI), or better just "Kapitalizace"

Just looking at how German and Spanish translations solved it:

       /* en      */ "Match Case",
        /* cs      */ "Rozlišovat velká a malá písmena",
        /* de      */ "Groß/Klein",
        /* es      */ "May/Min",

Thank you for such a superb translation! @ioma8

@lhecker lhecker added the A-localization Area: Localization label Jun 10, 2025
@ioma8
Copy link
Author

ioma8 commented Jun 25, 2025

I resolved the merge conflicts as well as used the shorter form for "Match case" translation key as suggested by @jakubtalich

I am asking for merging this PR now.

@ioma8 ioma8 requested a review from veldik June 25, 2025 10:26
@ioma8
Copy link
Author

ioma8 commented Jul 3, 2025

How do i get this PR approved? I think I fullfill all requirements.

@jakubtalich
Copy link

How do i get this PR approved? I think I fullfill all requirements.

"This workflow is awaiting approval from a maintainer in #402"

@lhecker
Copy link
Member

lhecker commented Jul 3, 2025

How do i get this PR approved? I think I fullfill all requirements.

That is correct, but we don't have the available binary space to ship another 17 languages (I'm sure more will be coming in the future). At some point I'll finish #179 and merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-localization Area: Localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants